fuzz: Print error message when FUZZ is missing #27672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
Author
|
(Also contains some no-op code to allow for easier hacking) |
maflcko
force-pushed
the
2305-fuzz-log-FUZZ-
branch
2 times, most recently
from
faa4ef8 to
fac8058
Compare
maflcko
force-pushed
the
2305-fuzz-log-FUZZ-
branch
from
fac8058 to
fa32aa5
Compare
added 2 commits
May 22, 2023 10:02
Also, add missing includes.
This documents the state in the CI output and may help debugging in case of failure.
maflcko
force-pushed
the
2305-fuzz-log-FUZZ-
branch
from
fa32aa5 to
fa1b3ab
Compare
Member
Author
|
Added a commit to also improve fuzz logging in the CI system: https://cirrus-ci.com/task/4987695903014912?logs=ci#L222 |
Member
|
ACK fa1b3ab |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 23, 2023
fa1b3ab ci: Log qa-assets repo last commit (MarcoFalke) fa22966 fuzz: Print error message when FUZZ is missing (MarcoFalke) Pull request description: Some trivial UX improvements. * Change the exit code for `PRINT_ALL_FUZZ_TARGETS_AND_ABORT` and `WRITE_ALL_FUZZ_TARGETS_AND_ABORT` to `EXIT_SUCCESS` instead of `Aborted (core dumped)`. * Print readable error message when `FUZZ` is missing instead of `Aborted (core dumped)`. * Clarify that a fuzz target needs to be compiled into the executable. ACKs for top commit: dergoegge: ACK fa1b3ab Tree-SHA512: 065ef8920449c64b3516f89a61cb397b505eccf531318c4f3830895d5ff6cd7ae2525cb857320481e3d0ed0b2f8a522cd8f7835e69f021241b6ec297a6102fc8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some trivial UX improvements.
PRINT_ALL_FUZZ_TARGETS_AND_ABORTandWRITE_ALL_FUZZ_TARGETS_AND_ABORTtoEXIT_SUCCESSinstead ofAborted (core dumped).FUZZis missing instead ofAborted (core dumped).