Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented May 15, 2023

This source code is the wrong place to document historic and now irrelevant details. Also, while touching the docs, clarify that the BIP 35 mempool message type is currently also guarded by the BIP 111 NODE_BLOOM flag, even though BIP 111 does not mention the mempool message type.

@DrahtBot
Copy link
Contributor

DrahtBot commented May 15, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK 0xB10C, dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@0xB10C
Copy link
Contributor

0xB10C commented May 15, 2023

ACK facbcd3

@fanquake fanquake requested review from dergoegge, glozow and jnewbery May 15, 2023 11:09
Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK facbcd3

@fanquake fanquake merged commit 30d6c7d into bitcoin:master May 31, 2023
@maflcko maflcko deleted the 2305-doc-bloom- branch May 31, 2023 10:50
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 31, 2023
@bitcoin bitcoin locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants