doc: clarify processing of mempool-msgs when NODE_BLOOM #27559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under which circumstances we process received 'mempool' P2P messages caused confusion in bitcoin#27426. Rather than bikeshedding the formulation of the IF-statement, this adds a comment clarifing when we process the message. Also, correcting the comment of `m_send_mempool`. Co-authored-by: willcl-ark <[email protected]>
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
|
ACK 4581a68 |
Member
|
ACK 4581a68 |
Member
|
cc also @jnewbery @mzumsande @sdaftuar |
glozow
reviewed
May 3, 2023
Contributor
|
Post-merge ACK 4581a68 |
Contributor
|
ACK 4581a68 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 4, 2023
maflcko
reviewed
May 10, 2023
| /** Whether the peer has requested us to send our complete mempool. Only | ||
| * permitted if the peer has NetPermissionFlags::Mempool. See BIP35. */ | ||
| * permitted if the peer has NetPermissionFlags::Mempool or we advertise | ||
| * NODE_BLOOM. See BIP35. */ |
Member
There was a problem hiding this comment.
I think it makes sense to also document this in src/protocol.h, which generally refers to the p2p version and the BIP number. I read BIP 35, 37, and 111, but I couldn't find a mention that the message type is guarded by NODE_BLOOM. So maybe this can also be mentioned in src/protocol.h?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under which circumstances we process received 'mempool' P2P messages caused confusion in #27426. Rather than bike-shedding the formulation of the IF-statement, this adds a comment clarifying when we process the message. Also, correcting the
m_send_mempooldescription.