test: added coverage to rpc_scantxoutset.py #27453
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
fanquake
changed the title
|
LGTM |
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Concept ACK,
and warm welcome as a new contributor!
Looks good to me, just one nit: the commit subject line has a missing-character-typo in the functional test filename (rpc_cantxoutset.py -> should be rpc_scantxoutset.py), can you fix that please?
|
lgtm ACK ecb79aed4d847d8c95936ac80b7e137f9c17b6f8 |
Included a test that checks if an invalid first argument is entered we receive a rpc error. The rpc should fail if "start", "status" or "abort" is not the first command.
kevkevinpal
force-pushed
the
test/scantxoutsetInvalid
branch
from
ecb79ae to
24d55fb
Compare
Thanks! Fixed 24d55fb |
|
lgtm ACK 24d55fb |
24d55fb test: added coverage to rpc_scantxoutset.py (kevkevin) Pull request description: Included a test that checks if an invalid first argument is entered we receive a rpc error. The rpc should fail if "start", "status" or "abort" is not the first command. Relavant: mentioned in bitcoin#27422 ACKs for top commit: MarcoFalke: lgtm ACK 24d55fb theStack: ACK 24d55fb Tree-SHA512: 4b804235d3fa17c7bf492068ab47c1f87cb6cfc1a428c51e273ec059d3c41f581bcc467bb5d6d8bbf2fab14c60cd1c52a30c50009efe1c9b5adee70c88897ad9
6 participants
Included a test that checks if an invalid first argument is entered we receive a rpc error. The rpc should fail if "start", "status" or "abort" is not the first command.
Relavant: mentioned in #27422