build: remove ancient unused define #27420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic define was removed in upstream miniupnpc in 2014: miniupnp/miniupnp@f6774e3 Noticed while reviewing hebasto's new CMake buildsystem: hebasto#12 (comment)
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Contributor
|
utACK 9fbc5fc |
sedited
approved these changes
Apr 4, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 5, 2023
9fbc5fc build: remove ancient unused define (Cory Fields) Pull request description: The generic define was removed in [upstream miniupnpc in 2014](miniupnp/miniupnp@f6774e3). Noticed while reviewing hebasto's new CMake buildsystem: hebasto#12 (comment). ACKs for top commit: RandyMcMillan: utACK 9fbc5fc hebasto: ACK 9fbc5fc TheCharlatan: ACK 9fbc5fc Tree-SHA512: 2075a2e63441e32d939c23f30f811c73dd1ab1ddcc9e6bf079cc8060e77d9a2a6d707add7b72e9251939a53b53e28a134e9bb330ccf3556244497728f1b091ae
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic define was removed in upstream miniupnpc in 2014.
Noticed while reviewing hebasto's new CMake buildsystem: hebasto#12 (comment).