-
Notifications
You must be signed in to change notification settings - Fork 38.7k
util: Use steady clock instead of system clock to measure durations #27405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
|
Concept ACK |
fa069d8 to
ffff99d
Compare
martinus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
|
Concept ACK |
ffff99d to
fa83fb3
Compare
|
ACK fa83fb3 This is a nice cleanup to the clocks. There are a few time values left as other types in the codebase, but it doesn't make sense to change them as they are being used as those types by other components (mainly libevent it seems). |
|
Concept ACK |
martinus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review ACK fa83fb3, also ran all tests. All usages of the steady_clock are just for duration measurements, so the change to a different epoch is ok.
…asure durations includes: - fa1d804
…asure durations includes: - fa1d804
backport: merge bitcoin#19521, bitcoin#22047, bitcoin#21796, bitcoin#21767, bitcoin#24133, bitcoin#24921, bitcoin#27988, partial bitcoin#24117, bitcoin#24138, bitcoin#27405 (assumeutxo: part 5)
GetTimeMillishas multiple issues:Fix all issues here.