test: remove GetRNGState lsan suppression
#27362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
Member
Author
|
Switched to basing on #27363. |
I am no-longer seeing this. Can anyone recreate the false-positive?
Member
Author
|
Rebased past #27363. |
Member
|
lgtm ACK 71b3e9b |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 1, 2023
71b3e9b sanitizers: remove GetRNGState lsan suppression (fanquake) Pull request description: I am no-longer seeing this, testing with the native_asan job over `x86_64` (Ubuntu 22.04) and `aarch64` (Fedora 37). Can anyone recreate the false-positive? ACKs for top commit: MarcoFalke: lgtm ACK 71b3e9b hebasto: ACK 71b3e9b, tested on Ubuntu 22.04 x86_64. Tree-SHA512: 63020327d61acd6c94c6c278c9c4d72aedc10253fa172bcf9353bcad4c28d068bee824969eb3ce92152244831df8fe92cffae536453c8073a4fda74dfdfbcefa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am no-longer seeing this, testing with the native_asan job over
x86_64(Ubuntu 22.04) andaarch64(Fedora 37).Can anyone recreate the false-positive?