Skip to content

Update chainparams for 25.x #27223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnny9 wants to merge 1 commit into from
Closed

Update chainparams for 25.x #27223

johnny9 wants to merge 1 commit into from

Conversation

@johnny9
Copy link
Contributor

@johnny9 johnny9 commented Mar 7, 2023

Update chain parameters for upcoming major release. See doc/release-process.md for review instructions. Followed instructions from #24418 closely as well.

  • m_assumed_blockchain_size, m_assumed_chain_state_size:

mainnet

.bitcoin$ du -h --exclude=signet --exclude=testnet3 .
0       ./wallets
117M    ./blocks/index
489G    ./blocks
4.9G    ./chainstate
494G    .
.bitcoin$ python3
Python 3.11.1 (main, Jan  6 2023, 00:00:00) [GCC 12.2.1 20221121 (Red Hat 12.2.1-4)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> 494*1.1
543.4000000000001
>>> 5*1.1
5.5

testnet3 (no changes needed to params)

.bitcoin$ du -h testnet3/
0       testnet3/wallets
648M    testnet3/blocks/index
31G     testnet3/blocks
1.4G    testnet3/chainstate
33G     testnet3/
.bitcoin$ python3
Python 3.11.1 (main, Jan  6 2023, 00:00:00) [GCC 12.2.1 20221121 (Red Hat 12.2.1-4)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> 33*1.1
36.300000000000004
>>> 1.4*1.1
1.5

signet (no changes needed to params)

.bitcoin$ du -h signet/
0       signet/wallets
19M     signet/blocks/index
714M    signet/blocks
16K     signet/chainstate
755M    signet/
  • chainTxData:

mainnet

$ bitcoin-cli getbestblockhash
00000000000000000001ab5cdb8f56ebc12419a1c12a528f576c535e976ae5e9

$ bitcoin-cli getchaintxstats 4096 00000000000000000001ab5cdb8f56ebc12419a1c12a528f576c535e976ae5e9
{
  "time": 1678203665,
  "txcount": 811834437,
  "window_final_block_hash": "00000000000000000001ab5cdb8f56ebc12419a1c12a528f576c535e976ae5e9",
  "window_final_block_height": 779756,
  "window_block_count": 4096,
  "window_tx_count": 8082254,
  "window_interval": 2295173,
  "txrate": 3.521413854206197
}

testnet

bitcoin-cli -testnet getbestblockhash
0000000000000011687aa6730b65137ca2549024b71bfda69d9eaf5eb7336749[

bitcoin-cli -testnet getchaintxstats 4096 0000000000000011687aa6730b65137ca2549024b71bfda69d9eaf5eb7336749
{
  "time": 1678204040,
  "txcount": 65041246,
  "window_final_block_hash": "0000000000000011687aa6730b65137ca2549024b71bfda69d9eaf5eb7336749",
  "window_final_block_height": 2423291,
  "window_block_count": 4096,
  "window_tx_count": 166030,
  "window_interval": 2434181,
  "txrate": 0.06820774626044654
}

signet

$ bitcoin-cli -signet getbestblockhash
0000001681c52f68f3b148a931574d23a54153231d4a6a0161799950e2453d97

$ bitcoin-cli -signet getchaintxstats 4096 0000001681c52f68f3b148a931574d23a54153231d4a6a0161799950e2453d97
{
  "time": 1678203585,
  "txcount": 2207891,
  "window_final_block_hash": "0000001681c52f68f3b148a931574d23a54153231d4a6a0161799950e2453d97",
  "window_final_block_height": 133021,
  "window_block_count": 4096,
  "window_tx_count": 18193,
  "window_interval": 2559149,
  "txrate": 0.007109003813377025
}
  • nMinimumChainWork, defaultAssumeValid:

mainnet

$ bitcoin-cli getblockheader 00000000000000000001ab5cdb8f56ebc12419a1c12a528f576c535e976ae5e9
{
  "hash": "00000000000000000001ab5cdb8f56ebc12419a1c12a528f576c535e976ae5e9",
  "confirmations": 2,
  "height": 779756,
  "version": 722239488,
  "versionHex": "2b0c8000",
  "merkleroot": "12b126d43ec53fc50c3e5bd38d0849f765463be5ba0f3b113a837acc3dc9c73c",
  "time": 1678203665,
  "mediantime": 1678201388,
  "nonce": 1118234730,
  "bits": "170689a3",
  "difficulty": 43053844193928.45,
  "chainwork": "00000000000000000000000000000000000000004200315292c8bdc13e546bdc",
  "nTx": 3502,
  "previousblockhash": "00000000000000000000f94f67e1da0927aa6c1327953513841ab9dbf4e221a6",
  "nextblockhash": "000000000000000000060227179ffe953752753c2fc4e81b48f576227bc556bf"
}

testnet

$ bitcoin-cli -testnet getblockheader 0000000000000011687aa6730b65137ca2549024b71bfda69d9eaf5eb7336749
{
  "hash": "0000000000000011687aa6730b65137ca2549024b71bfda69d9eaf5eb7336749",
  "confirmations": 1,
  "height": 2423291,
  "version": 538968064,
  "versionHex": "20200000",
  "merkleroot": "737a77e585b97bfb118fe55ba23a80e47da6798c58800c7824a061cb5f96fc7b",
  "time": 1678204040,
  "mediantime": 1678201426,
  "nonce": 2256300948,
  "bits": "192a0b9d",
  "difficulty": 102149233.8892645,
  "chainwork": "0000000000000000000000000000000000000000000009187b7c3b56dbc42a6f",
  "nTx": 53,
  "previousblockhash": "00000000000000137f3c43f8d2da8028c441d61717146786ca3ed3e203ad2e17"
}

signet

$ bitcoin-cli -signet getblockheader 0000001681c52f68f3b148a931574d23a54153231d4a6a0161799950e2453d97
{
  "hash": "0000001681c52f68f3b148a931574d23a54153231d4a6a0161799950e2453d97",
  "confirmations": 1,
  "height": 133021,
  "version": 536870912,
  "versionHex": "20000000",
  "merkleroot": "93393537b960a7f66952ac890d28edf8544ad03ef5c31d75a829c849e424bae8",
  "time": 1678203585,
  "mediantime": 1678201021,
  "nonce": 18855356,
  "bits": "1e01562c",
  "difficulty": 0.002922463283140783,
  "chainwork": "0000000000000000000000000000000000000000000000000000017aeaa97dea",
  "nTx": 1,
  "previousblockhash": "00000120da11e3c849cbca953bb92f5b24539ad9a8476217f82b7633a5bbe9b1"
}

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 7, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #26857 (OP_VAULT draft by jamesob)
  • #26201 (Remove Taproot activation height by Sjors)
  • #26177 (refactor / kernel: Move non-gArgs chainparams functionality to kernel by TheCharlatan)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@johnny9
Copy link
Contributor Author

johnny9 commented Mar 7, 2023

Might have jumped the gun on this. Says "Before branch-off"

@fanquake
Copy link
Member

fanquake commented Mar 7, 2023

Might have jumped the gun on this.

Yea, it's a bit too early to be doing this. See #26549.

This was referenced Mar 7, 2023
Closed
Open
Merged
@johnny9
Copy link
Contributor Author

johnny9 commented Mar 8, 2023

Closing for now, will reopen closer to branch off

@johnny9 johnny9 closed this Mar 8, 2023
@fanquake fanquake mentioned this pull request Apr 18, 2023
Merged
@fanquake
Copy link
Member

fanquake commented Apr 18, 2023

Done in #27482 (added you as co-author).

fanquake added a commit that referenced this pull request Apr 20, 2023
@fanquake
Merge #27482: kernel: chainparams updates for 25.x
3133d93 
a2bef80 kernel: update m_assumed_* chain params for 25.x (fanquake)
4128e01 kernel: update chainTxData for 25.x (fanquake)
00b2b11 kernel: update nMinimumChainWork & defaultAssumeValid for 25.x (fanquake)
07fcc0a doc: update references to kernel/chainparams.cpp (fanquake)

Pull request description:

  Update chainparams pre `25.x` branch off.
  Co-Author in the commits as a PR (#27223) had previously been opened too-early to do the same.

  Note: Remember that some variance is expected in the `m_assumed_*` sizes.

ACKs for top commit:
  achow101:
    ACK a2bef80
  josibake:
    ACK a2bef80
  gruve-p:
    ACK a2bef80
  dergoegge:
    ACK a2bef80 on the new mainnet params

Tree-SHA512: 0b19c2ef15c6b15863d6a560a1053ee223057c7bfb617ffd3400b1734cee8f75bc6fd7f04d8f8e3f5af6220659a1987951a1b36945d6fe17d06972004fd62610
@bitcoin bitcoin locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnny9 @DrahtBot @fanquake