Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Feb 2, 2023

Build against glibc 2.27 for all Linux builds (previously only used for RISC-V), and at the same time, increase our minimum required glibc to 2.27 (2018). This would drop support for Ubuntu Xenial (16.04) & Debian Stretch (9), from the produced release binaries. Compiling from source on those systems may be possible, assuming you can install a recent enough compiler/toolchain etc.

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 2, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #25573 ([POC] guix: produce a fully -static-pie x86_64 bitcoind using GCC and glibc by fanquake)
  • #24123 (build: Pointer Authentication and Branch Target Identification for aarch64 Linux (Guix) by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko
Copy link
Member

maflcko commented Feb 2, 2023

For reference, this would affect less than 2% of snap users:

stats_feb2

@fanquake fanquake force-pushed the glibc_2_27 branch 2 times, most recently from 69bd3d9 to 825d228 Compare February 6, 2023 13:23
@luke-jr
Copy link
Member

luke-jr commented Feb 6, 2023

This would drop support for Ubuntu Xenial (16.04) & Debian Stretch (9).

Only for the binaries, right? Building from source should still be possible, I'd expect. (Though I'm not sure if we care, it might be good to clarify in the description)

@fanquake
Copy link
Member Author

fanquake commented Feb 7, 2023

(Though I'm not sure if we care, it might be good to clarify in the description)

Added a note to the PR description.

@fanquake fanquake marked this pull request as ready for review February 7, 2023 13:54
@hebasto
Copy link
Member

hebasto commented Feb 7, 2023

Concept ACK.

@hebasto
Copy link
Member

hebasto commented Feb 10, 2023

Guix builds:

380420dbd00aa112f988bc7ab7e226f0662499d2008582bf325f47cc1a02a54d  guix-build-d1c8711d8a17/output/aarch64-linux-gnu/SHA256SUMS.part
e2b77aaac9a2fd67a8b66892083802b28163b97906efc352d98b03d43f8371ab  guix-build-d1c8711d8a17/output/aarch64-linux-gnu/bitcoin-d1c8711d8a17-aarch64-linux-gnu-debug.tar.gz
fec876f1039980d1706d938d2255d57ca6dd26163d4a31bee1704a0b7ebf90c6  guix-build-d1c8711d8a17/output/aarch64-linux-gnu/bitcoin-d1c8711d8a17-aarch64-linux-gnu.tar.gz
acaaf65a53ebe2259256c2f1bd01c818a8e5ae1b7d68b9e8c90505a5ca8496e5  guix-build-d1c8711d8a17/output/arm-linux-gnueabihf/SHA256SUMS.part
9e88984b59284375590f6a58d91c6656bc01a3144ecf1f68b4745e2d47e26e14  guix-build-d1c8711d8a17/output/arm-linux-gnueabihf/bitcoin-d1c8711d8a17-arm-linux-gnueabihf-debug.tar.gz
11bff60d541ccc8d397d05af90e425b0e29732f6dbc339343a0e7d1ac65f0968  guix-build-d1c8711d8a17/output/arm-linux-gnueabihf/bitcoin-d1c8711d8a17-arm-linux-gnueabihf.tar.gz
993e2493c407ea8c7dd5fccc98c849467b967001b4a1151d43c570bf767bc9bb  guix-build-d1c8711d8a17/output/arm64-apple-darwin/SHA256SUMS.part
bbe0c2faba5fccfccced9e888edad57c45fa6a7ee96e0d823186556f2ebf737f  guix-build-d1c8711d8a17/output/arm64-apple-darwin/bitcoin-d1c8711d8a17-arm64-apple-darwin-unsigned.dmg
ecbab86e1b70c66aae0cfc6591a47fa2ae478238ee0a5ca2506fbac653fee39b  guix-build-d1c8711d8a17/output/arm64-apple-darwin/bitcoin-d1c8711d8a17-arm64-apple-darwin-unsigned.tar.gz
f6c2410e5fd357b0f5c0ab46bc507904bd1ba31b1b2cfe8f183c21f20e2876dc  guix-build-d1c8711d8a17/output/arm64-apple-darwin/bitcoin-d1c8711d8a17-arm64-apple-darwin.tar.gz
9c395364e92ff5489a51aab82b5630b578391549bba6f3d82f6ca4b03171d6db  guix-build-d1c8711d8a17/output/dist-archive/bitcoin-d1c8711d8a17.tar.gz
bd759857b26d0327e526efce9b6a5a93b12b427d2d948c9c16d363685bc565c4  guix-build-d1c8711d8a17/output/powerpc64-linux-gnu/SHA256SUMS.part
e7cb396838cb16b450c6610731081f4796fc32bbe950a47362b122e318a67109  guix-build-d1c8711d8a17/output/powerpc64-linux-gnu/bitcoin-d1c8711d8a17-powerpc64-linux-gnu-debug.tar.gz
f0cebc830796a431aa61fc92bfa49e4202d04cbfb5a4dad387e98de8beb12149  guix-build-d1c8711d8a17/output/powerpc64-linux-gnu/bitcoin-d1c8711d8a17-powerpc64-linux-gnu.tar.gz
6ec3fb20feb1ec195a0c875b881460f077d75ee9c76a84ff4e8ba5ab3f7a3a04  guix-build-d1c8711d8a17/output/powerpc64le-linux-gnu/SHA256SUMS.part
c3bd6420a515f7a78a28b8556d017dc780c87b264d1709e68125fe5e416eaab7  guix-build-d1c8711d8a17/output/powerpc64le-linux-gnu/bitcoin-d1c8711d8a17-powerpc64le-linux-gnu-debug.tar.gz
86a65f451ff949a35a15cbd6f6044b2da02c6c9ffb6a01b2115d676e5a1a2e2e  guix-build-d1c8711d8a17/output/powerpc64le-linux-gnu/bitcoin-d1c8711d8a17-powerpc64le-linux-gnu.tar.gz
2176716c09834e4ed1d64a9c5a7bc027a2ac7ad24282d225d938fcddacee7363  guix-build-d1c8711d8a17/output/riscv64-linux-gnu/SHA256SUMS.part
6f6f8855b06e907d62d5e514d9346cb9808a9168287fca4967d19bec6a04a0ee  guix-build-d1c8711d8a17/output/riscv64-linux-gnu/bitcoin-d1c8711d8a17-riscv64-linux-gnu-debug.tar.gz
05dd291d58124f077df1308be7248e17421ca21139a7e0aae3ca55a7d7036e55  guix-build-d1c8711d8a17/output/riscv64-linux-gnu/bitcoin-d1c8711d8a17-riscv64-linux-gnu.tar.gz
261bd1364f4c27c0f7ed3e6e2a47d1cc80b816cacc18bb5eaccb86925db055f0  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/SHA256SUMS.part
4fd7bd4fced41f4a24411bbaf8547e0ffede07dcb3099ae405f637abce9a4b62  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/bitcoin-d1c8711d8a17-x86_64-apple-darwin-unsigned.dmg
51f93649501ffb4ad4aa8319a2554fb7241203472daae3589f6a1cd7d885b538  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/bitcoin-d1c8711d8a17-x86_64-apple-darwin-unsigned.tar.gz
edd5aaa6c9584a2dedf95616ca9bdd52ae2a348e77270bfdc1e12066da1c4d08  guix-build-d1c8711d8a17/output/x86_64-apple-darwin/bitcoin-d1c8711d8a17-x86_64-apple-darwin.tar.gz
aef791b30bb3f4aa1998e50eff824a9ff3249b1e840405dcbc7d8af6a2253487  guix-build-d1c8711d8a17/output/x86_64-linux-gnu/SHA256SUMS.part
b6c632ab1f667edb0e207f6692472207fbcaf8f8c2fae0369d8c1542ea981b02  guix-build-d1c8711d8a17/output/x86_64-linux-gnu/bitcoin-d1c8711d8a17-x86_64-linux-gnu-debug.tar.gz
beea28998bd5d0e7b9984887bf5755e89d5b5e1ff1f84c05919520f72b1d115a  guix-build-d1c8711d8a17/output/x86_64-linux-gnu/bitcoin-d1c8711d8a17-x86_64-linux-gnu.tar.gz
a0a2515afe79a7afb0f09ed10a03d3e30eb3185a4eeb7e26b833bd4f70cbbea9  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/SHA256SUMS.part
6aff5418a3a8b489ae4306619f459dce895095a792cb8a7e910e4c3d79552d71  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64-debug.zip
34a32080c0f2ad2cb19c8bf0ef454fe3a745a746b68ff1dfcd5fe54fa8bc2188  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64-setup-unsigned.exe
580ac9aa16c39341d6b8484cf73dd7c7f9b881e0dc17fd2c307f0e141fd59807  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64-unsigned.tar.gz
7ca12110fd33cedd661ac9336243465c3dfef23d398228a60e91746b255e32ed  guix-build-d1c8711d8a17/output/x86_64-w64-mingw32/bitcoin-d1c8711d8a17-win64.zip

@DrahtBot
Copy link
Contributor

Guix builds

File commit 8126551
(master)
commit 957f75a3da9a8fcf9f3a6058b4f13a646150554d
(master and this pull)
SHA256SUMS.part a73068811366a45b... 0feb34932bab5047...
*-aarch64-linux-gnu-debug.tar.gz 7d6dbd46fe457676... dd699b9597abbd1d...
*-aarch64-linux-gnu.tar.gz 7520e7a059cc6684... a46ee1d8481c1378...
*-arm-linux-gnueabihf-debug.tar.gz d97bb1418d3b2316... 78a659fa032201c8...
*-arm-linux-gnueabihf.tar.gz a1f0448968727793... 2346a7c7c19f7d08...
*-arm64-apple-darwin-unsigned.dmg 19533f717272f916... c84e24017cfdd259...
*-arm64-apple-darwin-unsigned.tar.gz 57aff0ec6005a6db... 6a9d56a52e60ea87...
*-arm64-apple-darwin.tar.gz 862c6afeee71f8fb... e9922cb5c63d7b3e...
*-powerpc64-linux-gnu-debug.tar.gz 4b643f0b06967242... 5c3881c39a9705c5...
*-powerpc64-linux-gnu.tar.gz 2670bee5edf6c3b8... a70ff0cc80d1192f...
*-powerpc64le-linux-gnu-debug.tar.gz 6270c7d026c419f7... bba55696abbf1cf0...
*-powerpc64le-linux-gnu.tar.gz e3e4232270ff5aef... bfde6ce9d895a8dc...
*-riscv64-linux-gnu-debug.tar.gz f40af1d070e277c7... 4a0178ad468c88c3...
*-riscv64-linux-gnu.tar.gz 110762f167d43d69... 68bb2cd75fb79e39...
*-win64-debug.zip 4ac7737d97907d51... 08ae361ea1f0a8aa...
*-win64-setup-unsigned.exe 859d32a0947d4da7... 8145dca946e90d63...
*-win64-unsigned.tar.gz f43a32fecc0c1eee... 35dbfa54222ab803...
*-win64.zip 1cdb7f63ef9f70b2... 44c396b62f77af23...
*-x86_64-apple-darwin-unsigned.dmg 034a7debb3f5adbf... 89fb30f742f9016d...
*-x86_64-apple-darwin-unsigned.tar.gz f441fb040d56859a... bcf003d38d1fcb65...
*-x86_64-apple-darwin.tar.gz 79b5f8787c6a3720... fda1b1140a7cc4da...
*-x86_64-linux-gnu-debug.tar.gz e2dc9354ef2e4819... f48883fe397b5f60...
*-x86_64-linux-gnu.tar.gz 185e3a914236c77c... b2cc85a3bb95edb9...
*.tar.gz 3daf687b07d336f1... ceff29304bb13ee7...
guix_build.log 57232e42a42fca6d... 7c14bdc95c329da0...
guix_build.log.diff 9651c6ad07fd1455...

kwvg added a commit to kwvg/dash that referenced this pull request Jul 10, 2023
@bitcoin bitcoin locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants