refactor: Add BlockManager getters #26900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
Author
|
Required for #25781 in either case |
maflcko
force-pushed
the
2301-blockman-fun-
branch
from
facd93b to
faf7b4f
Compare
This was referenced Jan 17, 2023
Member
|
Code review ACK faf7b4f |
This was referenced Jan 19, 2023
brunoerg
approved these changes
Jan 26, 2023
jonatack
reviewed
Jan 27, 2023
| { | ||
| if (fImporting) return "Importing..."; | ||
| if (fReindex) return "Reindexing..."; | ||
| if (m_chainman.m_blockman.LoadingBlocks()) return "Loading blocks ..."; |
Member
There was a problem hiding this comment.
Nice refactoring. It looks like there is also a minor user-facing behavior change here, but at first glance only affecting RPC getblockfrompeer and probably not an issue.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 27, 2023
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 19, 2023
Summary: A dependency of a dependency of an assumeutxo related backport uses `IsPruneMode`, so let's backport these getters. There are some callsites in init.cpp missing in this diff due to a missing backport related to a warning when the disk space is low.There is no risk of breaking anything if this is backported later and it does not seem very important. > Add BlockManager::LoadingBlocks() bitcoin/bitcoin@fa0f043 > Add BlockManager::GetPruneTarget() bitcoin/bitcoin@fae71fe > Add BlockManager::IsPruneMode() bitcoin/bitcoin@faf7b4f This is a backport of [[bitcoin/bitcoin#26900 | core#26900]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D15003
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in #25781 (comment), but adding getters seems unrelated from removing globals, so I split it out for now.