test: Remove redundant key_to_p2pkh call #26894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
KolbyML
force-pushed
the
test-redundant-assignment
branch
from
2bd0214 to
61360e0
Compare
maflcko
changed the title
Member
|
ACK 61360e0 |
kouloumos
reviewed
Jan 16, 2023
Comment on lines
+126
to
128
| info = w1.getaddressinfo(key.p2pkh_addr) | ||
| assert_equal(info["ismine"], True) | ||
| assert_equal(info["ischange"], True) |
Contributor
There was a problem hiding this comment.
as you are touching this; for some reason, this is the only one of the related subtests that the test_address() helper method is not used.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 16, 2023
61360e0 test: Remove redundant function call (Kolby ML) Pull request description: Removed unnecessary function call and assignment `get_generate_key()` already calls `key_to_p2pkh()` and stores it in the object as p2pkh_addr. key.p2pkh_addr is already used for most testcases as well, so it is just a redundant call ACKs for top commit: MarcoFalke: ACK 61360e0 Tree-SHA512: d39117310d6630bad7a78c051e683dbfc77b27f6182014557fb900c1adaf5f1e12039c5a6c0ea50e908d4a8688da05f2deae701f12e06086d17dde86ae275ec5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary function call and assignment
get_generate_key()already callskey_to_p2pkh()and stores it in the object as p2pkh_addr.key.p2pkh_addr is already used for most testcases as well, so it is just a redundant call