build: allow NO_BOOST=1 & NO_LIBEVENT=1 in depends #26833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
Concept ACK. |
fanquake
force-pushed
the
allow_depends_no_boost_no_event
branch
from
9256e08 to
67c472c
Compare
Contributor
|
Concept ACK |
sedited
reviewed
Jan 10, 2023
hebasto
reviewed
Jan 13, 2023
fanquake
force-pushed
the
allow_depends_no_boost_no_event
branch
from
67c472c to
7fdeb80
Compare
hebasto
approved these changes
Jan 14, 2023
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK 7fdeb80, tested on Ubuntu 22.04:
$ cd depends
$ make clean
$ make NO_QT=1 NO_WALLET=1 NO_ZMQ=1 NO_UPNP=1 NO_NATPMP=1 NO_USDT=1 NO_BOOST=1 NO_LIBEVENT=1
copying packages:
to: /home/hebasto/git/bitcoin/depends/x86_64-pc-linux-gnu
Member
Author
|
Guix Build: 3f3d70a062b9e5524e2276dd5658a6b6d61c9dc6a7bc78f494852c602169b129 guix-build-7fdeb80441f4/output/aarch64-linux-gnu/SHA256SUMS.part
fdbbe581d0a0c1f223eea02808abcc060f3f739de68900b87b2afbdef1ff5269 guix-build-7fdeb80441f4/output/aarch64-linux-gnu/bitcoin-7fdeb80441f4-aarch64-linux-gnu-debug.tar.gz
73d08e1a327c75282ef6ab65718567fb2b97115c92e5aec5a38354d149ff7cad guix-build-7fdeb80441f4/output/aarch64-linux-gnu/bitcoin-7fdeb80441f4-aarch64-linux-gnu.tar.gz
e2aab27790676306dfb281720464bc4a07331538fd11330e47b66b477cff1d48 guix-build-7fdeb80441f4/output/arm-linux-gnueabihf/SHA256SUMS.part
a1de1d253bf64607fcb40aaf3a2e2c3f055c703c1c177ceda08ef079fcd5041f guix-build-7fdeb80441f4/output/arm-linux-gnueabihf/bitcoin-7fdeb80441f4-arm-linux-gnueabihf-debug.tar.gz
027126dcd44edd9d7dfeedda1c53014ed8bc0310aad8b9d964368d1d028c9fa9 guix-build-7fdeb80441f4/output/arm-linux-gnueabihf/bitcoin-7fdeb80441f4-arm-linux-gnueabihf.tar.gz
97b970c788750418addb7aff1b50a3a1389eb7e4e8d20ed0f779023842eef941 guix-build-7fdeb80441f4/output/arm64-apple-darwin/SHA256SUMS.part
430936a60cd8638a7b85608015c01aab18cc49d66c9d94fc3d9f70cbf99f6fd5 guix-build-7fdeb80441f4/output/arm64-apple-darwin/bitcoin-7fdeb80441f4-arm64-apple-darwin-unsigned.dmg
359cecf3468caea55449d90ac18ed3faaf271df7a697f58a76ed6ea98d7df5fa guix-build-7fdeb80441f4/output/arm64-apple-darwin/bitcoin-7fdeb80441f4-arm64-apple-darwin-unsigned.tar.gz
c44b99dcbbb8c4004e676c5ff1e1f8d4a70443f7f62a91c38fcae661a9cbdaf3 guix-build-7fdeb80441f4/output/arm64-apple-darwin/bitcoin-7fdeb80441f4-arm64-apple-darwin.tar.gz
f127cb319db1ae6360b5668b31b5a5882882b3a493b82e18b9219a2c9dbfd530 guix-build-7fdeb80441f4/output/dist-archive/bitcoin-7fdeb80441f4.tar.gz
b3059b80f8485a710010311c0ee298664184328f7a089ea012c3b734023640ee guix-build-7fdeb80441f4/output/powerpc64-linux-gnu/SHA256SUMS.part
a688a22fc329b2c327d588d33f5e20f68eb4e1e37b15ef831d076797172feba4 guix-build-7fdeb80441f4/output/powerpc64-linux-gnu/bitcoin-7fdeb80441f4-powerpc64-linux-gnu-debug.tar.gz
52bf8c3dd7ea543de91e2a5c82211bbf32adf238858b3923bc2c3fd705268fcb guix-build-7fdeb80441f4/output/powerpc64-linux-gnu/bitcoin-7fdeb80441f4-powerpc64-linux-gnu.tar.gz
4597b1d1ece10b6da6984faecd85427ac9fbd4c8efbfa4d8fe9b62599bea1028 guix-build-7fdeb80441f4/output/powerpc64le-linux-gnu/SHA256SUMS.part
334c2cf241e32338fc492d94ece26a2d425580190a23087b8313a868ed961d13 guix-build-7fdeb80441f4/output/powerpc64le-linux-gnu/bitcoin-7fdeb80441f4-powerpc64le-linux-gnu-debug.tar.gz
b24170d8bb5c77470b01129cc19d02aa4cc8eb28009232c7e518955748aada34 guix-build-7fdeb80441f4/output/powerpc64le-linux-gnu/bitcoin-7fdeb80441f4-powerpc64le-linux-gnu.tar.gz
a0c1a5004d96bc38dc470d3e92b790ebe8eee26b7f96dddfb02ea905de53aebb guix-build-7fdeb80441f4/output/riscv64-linux-gnu/SHA256SUMS.part
a92659662688791bcca689549540a193aca02a794d53c7898a063a93c62cc068 guix-build-7fdeb80441f4/output/riscv64-linux-gnu/bitcoin-7fdeb80441f4-riscv64-linux-gnu-debug.tar.gz
0771fe12bfbd8af94c70592bc4b76fec23545c7930cb2aedf752c02f5f16ee91 guix-build-7fdeb80441f4/output/riscv64-linux-gnu/bitcoin-7fdeb80441f4-riscv64-linux-gnu.tar.gz
2d42ff20b8850400eb1fcf78e0db720553321948557b13c113b279db55684c3c guix-build-7fdeb80441f4/output/x86_64-apple-darwin/SHA256SUMS.part
f68b40f13cc109dfc926f008139410719aca0ee1674fc2d346599d9179949d7b guix-build-7fdeb80441f4/output/x86_64-apple-darwin/bitcoin-7fdeb80441f4-x86_64-apple-darwin-unsigned.dmg
fa5fb50c7555e719021e44b9167da643fc12ce661639115940d1e2353d8b2c0f guix-build-7fdeb80441f4/output/x86_64-apple-darwin/bitcoin-7fdeb80441f4-x86_64-apple-darwin-unsigned.tar.gz
6e6a95690f8adc9680b5ca80c57216a6962b88ed9509adfb99166fd77d4a3cfe guix-build-7fdeb80441f4/output/x86_64-apple-darwin/bitcoin-7fdeb80441f4-x86_64-apple-darwin.tar.gz
dc82f7c14639e16e843e14b0fe2993f89882f29a7ceca06ef95e04ac55557523 guix-build-7fdeb80441f4/output/x86_64-linux-gnu/SHA256SUMS.part
10ad5fbb305c005621fb8f59b2046e9940cf1caaac35ca20d92c3d74f062ad10 guix-build-7fdeb80441f4/output/x86_64-linux-gnu/bitcoin-7fdeb80441f4-x86_64-linux-gnu-debug.tar.gz
67f1e033dc30cc70eb22df65877662fe94d5f03cba6c63ac0d178ac3829926e5 guix-build-7fdeb80441f4/output/x86_64-linux-gnu/bitcoin-7fdeb80441f4-x86_64-linux-gnu.tar.gz
07b8fcf86a8b39bdf6830b4f12cdbc2d45469a69800e026b257fa9d6f6d0cbb8 guix-build-7fdeb80441f4/output/x86_64-w64-mingw32/SHA256SUMS.part
f48e5424ac6b6eca3d59b80497590d66315da23edd12b89b5f9e8d5ceea9b9b0 guix-build-7fdeb80441f4/output/x86_64-w64-mingw32/bitcoin-7fdeb80441f4-win64-debug.zip
040bb2b6319b0a61449ee332e69096467360b7e91e105e538c3dfec8bc542f10 guix-build-7fdeb80441f4/output/x86_64-w64-mingw32/bitcoin-7fdeb80441f4-win64-setup-unsigned.exe
56dce754e737fd3be2ffaea48d3d31f8d04c1e65f53d2e233af2f56c6a16d126 guix-build-7fdeb80441f4/output/x86_64-w64-mingw32/bitcoin-7fdeb80441f4-win64-unsigned.tar.gz
1ede72369c34930f98dc6e394f4ca02bd39c4dc8fc84a855d65bcd45a5d33703 guix-build-7fdeb80441f4/output/x86_64-w64-mingw32/bitcoin-7fdeb80441f4-win64.zip |
Contributor
Member
|
I've just realized that https://github.com/bitcoin/bitcoin/blob/master/depends/README.md#dependency-options needs to be updated with new |
Member
Author
I don't think it matters that much, as standalone, they aren't really useful. Have added then in 26834 in any case. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 17, 2023
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 18, 2023
achow101
added a commit
that referenced
this pull request
Jan 27, 2023
44f3c7d contrib: remove install_db4.sh (fanquake) 14ce843 doc: add new NO_* options from #26833 (fanquake) Pull request description: Now that we can build a bdb-only depends prefix (#26833), there is no need to maintain a bdb-building bash script, that does the same thing as depends, except worse, as it's missing patches and workarounds. i.e #26623. Someone that wants to compile bdb themselves, but doesn't want to use other depends built libs, can do: ```bash make -C depends NO_BOOST=1 NO_LIBEVENT=1 NO_QT=1 NO_SQLITE=1 NO_NATPMP=1 NO_UPNP=1 NO_ZMQ=1 NO_USDT=1 ... to: /path/to/bitcoin/depends/x86_64-pc-linux-gnu ``` which gives them a BDB only prefix, and then compile using: ```bash export BDB_PREFIX="/path/to/bitcoin/depends/x86_64-pc-linux-gnu" ./autogen.sh ./configure \ BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" \ BDB_CFLAGS="-I${BDB_PREFIX}/include" ``` Wondering if we should extract the build bdb/legacy wallet docs somewhere, to avoid the repetition? ACKs for top commit: TheCharlatan: ACK 44f3c7d achow101: ACK 44f3c7d hebasto: ACK 44f3c7d jarolrod: ACK 44f3c7d Tree-SHA512: 50b33ae9df2ab94a1bd114e846cec16f647a61023b72f0d3e547a18db09c01d60bb7b42a04758212f4930314df03016feb6ebc96962dd8a8e26eb8cd4e0d167d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for removing
install_db4.sh. So we can invokemake -C depends/ NO_BOOST=1 NO_LIBEVENT=1 NO_QT=1 NO_SQLITE=1 NO_NATPMP=1 NO_ZMQ=1 NO_UPNP=1 NO_USDT=1and get a prefix with only bdb headers/libs.