Bitcoin-Qt: setup testnet GUI directly #2672
Conversation
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/6eec1c80a624f594209a0b3bc464dfa914267574 for binaries and test log. |
|
ACK |
|
Works for me. ACK for after 0.8.2 release Sidenote: This is all great and al, but can we start focusing on normal users again. Only a very small percentage of users will ever even see the testnet. |
|
@laanwj I'm fine with your sidenode, but as I use Testnet even more often than Mainnet, I wanted to make this "perfect" ;). |
src/qt/bitcoingui.cpp
Outdated
There was a problem hiding this comment.
I don't like this direct call to a core function (GetBoolArg) in GUI code. Can you pass this as a parameter to the constructor?
There was a problem hiding this comment.
Yes, I'll change that.
Edit: Can you take another look?
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/725a6283d1c3545a800184cf0fe5cae46f1d2fda for binaries and test log. |
- this directly sets up all GUI elements that have testnet special-casing without first setting up main net stuff and changing afterwards (titles, icons etc.) - also fixes 2 wrong icons shown during testnet usage on our toolbar
Bitcoin-Qt: setup testnet GUI directly
4 participants
without first setting up main net stuff and chaning afterwards (titles,
icons etc.)
@jonasschnelli Can you take a look if testnet icon is still shown imediately on Mac?