Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Dec 5, 2022

By using the already existing miniwallet, the test can be run even when no wallet is compiled.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 5, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK glozow, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #20892 (tests: Run both descriptor and legacy tests within a single test invocation by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko maflcko force-pushed the 2212-test-mini-wallet-mempool- branch from fa2011f to fa43f60 Compare December 5, 2022 12:13
@maflcko
Copy link
Member Author

maflcko commented Dec 5, 2022

It doesn't matter if the txs are descendants/ancestors of each other, so I just did that to make the diff even smaller.

@glozow
Copy link
Member

glozow commented Dec 5, 2022

ACK fa43f60

  • AFAICT code in test does effectively the same thing as before
  • test still runs when I disable wallet
  • test still passes normally, fails if I delete certain line of LoadMempool or DumpMempool

@achow101
Copy link
Member

achow101 commented Dec 5, 2022

ACK fa43f60

@achow101 achow101 merged commit 7734a01 into bitcoin:master Dec 5, 2022
@maflcko maflcko deleted the 2212-test-mini-wallet-mempool-🚌 branch December 6, 2022 10:19
@bitcoin bitcoin locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants