test: Fix intermittent issue in rpc_net.py #26630
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
vertiond
pushed a commit
to vertiond/bitcoin
that referenced
this pull request
Dec 4, 2022
…prune.py 201b9a0 test: fix intermittent failure in feature_index_prune.py (Martin Zumsande) Pull request description: I can't reproduce the error from bitcoin#26630 locally, but from analying the logs I think the problem is the following: After calling `sync_blocks`, we didn't check that the indexes have caught up to the tip before performing the manual pruning. This could possibly lead to prune blockers with a lower height than the expected 2489, which do appear in the logs of the failed CI runs, e.g. - `2022-10-27T21:14:17.703920Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\validation.cpp:2395] [FlushStateToDisk] [prune] coinstatsindex limited pruning to height 2488` ([Cirrus](https://cirrus-ci.com/task/5443742333665280?logs=functional_tests#L2506)) So, this should be fixed by a call to `sync_index`. Fixes bitcoin#26330 ACKs for top commit: brunoerg: crACK 201b9a0 Tree-SHA512: fb7023c9eb2ba6d0e69e059a401453cbdf63abc6804543dffcf36ba9f93c9cd13209e57aa5536d94b2e420c9d4cd0b1a7eff1adadd19aa7b3c33f592502e1bc0
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 5, 2022
fadf7b8 test: Fix intermittent issue in rpc_net.py (MarcoFalke) Pull request description: Both nodes must be aware of the closed connections before re-connecting, otherwise the test will fail. Fixes bitcoin#25741 ACKs for top commit: jarolrod: ACK fadf7b8 Tree-SHA512: 0492dd59a46516007e903fe8f6288982e305d4fd152a0297dd60e10ac663efc9bdc0bc6d1d2c6ec5f239196dac08319f37b079401fe057e4864b117b0fd9dcbc
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 25, 2023
…prune.py 201b9a0 test: fix intermittent failure in feature_index_prune.py (Martin Zumsande) Pull request description: I can't reproduce the error from bitcoin#26630 locally, but from analying the logs I think the problem is the following: After calling `sync_blocks`, we didn't check that the indexes have caught up to the tip before performing the manual pruning. This could possibly lead to prune blockers with a lower height than the expected 2489, which do appear in the logs of the failed CI runs, e.g. - `2022-10-27T21:14:17.703920Z [C:\Users\ContainerAdministrator\AppData\Local\Temp\cirrus-ci-build\src\validation.cpp:2395] [FlushStateToDisk] [prune] coinstatsindex limited pruning to height 2488` ([Cirrus](https://cirrus-ci.com/task/5443742333665280?logs=functional_tests#L2506)) So, this should be fixed by a call to `sync_index`. Fixes bitcoin#26330 ACKs for top commit: brunoerg: crACK 201b9a0 Tree-SHA512: fb7023c9eb2ba6d0e69e059a401453cbdf63abc6804543dffcf36ba9f93c9cd13209e57aa5536d94b2e420c9d4cd0b1a7eff1adadd19aa7b3c33f592502e1bc0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both nodes must be aware of the closed connections before re-connecting, otherwise the test will fail.
Fixes #25741