Skip to content

Conversation

@pshep
Copy link

@pshep pshep commented May 17, 2013

*_t types are not defined. Swap for unsigned int and unsigned char etc.

*_t types are not defined. Swap for unsigned int and unsigned char etc.
@gmaxwell
Copy link
Contributor

This is the wrong thing to do. We need specific sizes for specific normative behavior in many places, not all systems use the same sizes for primitive types. The stdint.h _t named size types are standards specified by SUS and in C++11.

@pshep
Copy link
Author

pshep commented May 17, 2013

Ah right. Compiling for another platform and these aren't defined - throws errors. Searched the rest of the bitcoin code and saw no other instances of *_t being used. It's unique to this file (well, aside from LevelDB)

@pshep pshep closed this May 17, 2013
@BitcoinPullTester
Copy link

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/16ecc9e41f0f6c11c5848ac5b697a1354c12a1d1 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

@luke-jr
Copy link
Member

luke-jr commented May 17, 2013

Eventually, it would be nice to migrate everything bit-specific to the standard [u]intN_t types, but the last attempt to do so had some issues. In addition to C++11, stdint.h was also part of C99 (1999, over 13 years ago) - perhaps you can get the header that way somehow?

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants