wallet: Migrate non-HD keys with single combo containing a list of keys #26627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
achow101
force-pushed
the
migrate-nonhd-key-list
branch
from
5d4005b to
8e60255
Compare
This was referenced Dec 3, 2022
Closed
achow101
force-pushed
the
migrate-nonhd-key-list
branch
from
8e60255 to
ce7c534
Compare
This was referenced Jan 10, 2023
achow101
force-pushed
the
migrate-nonhd-key-list
branch
from
ce7c534 to
ff810de
Compare
achow101
force-pushed
the
migrate-nonhd-key-list
branch
2 times, most recently
from
bdb3f63 to
e60fdf3
Compare
achow101
force-pushed
the
migrate-nonhd-key-list
branch
from
e60fdf3 to
4d43312
Compare
achow101
force-pushed
the
migrate-nonhd-key-list
branch
from
4d43312 to
bdf0dbe
Compare
achow101
force-pushed
the
migrate-nonhd-key-list
branch
from
bdf0dbe to
5d205b8
Compare
Member
|
Wouldn't #20018 address most performance concerns of having a large number of |
Member
Author
Yes, but these approaches aren't mutually exclusive, and I'd like to get feedback on both. |
achow101
force-pushed
the
migrate-nonhd-key-list
branch
from
5d205b8 to
96dea9d
Compare
achow101
force-pushed
the
migrate-nonhd-key-list
branch
from
96dea9d to
c6e00a4
Compare
achow101
force-pushed
the
migrate-nonhd-key-list
branch
from
c6e00a4 to
a15f10a
Compare
achow101
force-pushed
the
migrate-nonhd-key-list
branch
2 times, most recently
from
fc406a1 to
036cf7f
Compare
ListPubkeyProvider is a ranged PubkeyProvider that returns individual public keys that it was constructed with.
A new KEY expression is introduced which takes a list of non-ranged public keys. This expression itself is ranged and can provide the key at a particular index. It can take any KEY as long as it is not ranged.
Instead of having several thousand individual combo descriptors, have a single large combo descriptor with a list of keys. This will improve performance in IsMine and other similar areas.
achow101
force-pushed
the
migrate-nonhd-key-list
branch
from
036cf7f to
dd1c9af
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #26626
This PR changes the legacy to descriptor wallet migration from creating a new
combo()for every individual key to creating one largecombo()that has a list of every key. This improves the performance of the migrated wallet as it will only have one DescriptorSPKM for all of the non-HD keys.Note that this does not affect previously migrated wallets. Such wallets will still have a
combo()for every key.