[23.x] GUI backports #26522
Merged
[23.x] GUI backports #26522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOS 13 sends a window focus change notification after the main window has been destroyed but before the QTApplication has been destroyed. This results in the menu bar receiving a notification despite it no longer existing. The solution is to pass the main window as context when subscribing to the notifications. Qt automatically unsubscribes to notifications if the sender OR context is destroyed. Github-Pull: bitcoin-core/gui#680 Rebased-From: 8a5014c
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
|
fanquake
added a commit
that referenced
this pull request
Nov 22, 2022
87c2ff8 doc: add release notes for 23.1rc2 (fanquake) 5b2c99e doc: Update manual pages for 23.1rc2 (fanquake) a02ae07 build: Bump version to 23.1rc2 (fanquake) a1fcd56 doc: add 23.0 relase notes (fanquake) Pull request description: Bump the version to 23.1rc2. Regenerate the man pages. Add historical 23.0 release notes. Add WIP 23.1 release notes. Changes since rc1: * #26474 * #26522 ACKs for top commit: hebasto: ACK 87c2ff8, I have reviewed the code and it looks OK, I agree it can be merged. jarolrod: ACK 87c2ff8 Tree-SHA512: f185c33bfe2bf26f9df48f8d1e95ab784fef055bc7465282e2418960d348bd8b35f8fc57808b47250f8536a9def3be2d1dbe8ae309f052a81220925c425108f1
jamesdorfman
added a commit
to jamesdorfman/elements
that referenced
this pull request
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports: