Skip to content

Conversation

@bitcoinhodler
Copy link
Contributor

There never was a deriveaddress RPC, from what I can tell. It was always called deriveaddresses (plural).

@DrahtBot DrahtBot added the Docs label Oct 30, 2022
Copy link
Contributor

@Zero-1729 Zero-1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

It seems it was most likely a typo, given the RPC name is accurate at the beginning of the doc.

Perhaps, consider making the commit more explicit about the change, i.e. doc: correct deriveaddresses RPC name or something similar.

@bitcoinhodler
Copy link
Contributor Author

Perhaps, consider making the commit more explicit about the change, i.e. doc: correct deriveaddresses RPC name or something similar.

Done

@bitcoinhodler bitcoinhodler changed the title doc: correct RPC name doc: correct deriveaddresses RPC name Oct 30, 2022
Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0f38524

Checked via $ git grep "deriveaddress[^e]" that this is the only instance where the RPC is misspelled like this. Thanks for fixing!

Copy link
Contributor

@Zero-1729 Zero-1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0f38524

LGTM

@maflcko maflcko merged commit c75c0d8 into bitcoin:master Oct 31, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 31, 2022
@bitcoinhodler bitcoinhodler deleted the docfix branch October 31, 2022 20:35
@bitcoin bitcoin locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants