-
Notifications
You must be signed in to change notification settings - Fork 38.7k
test: Remove spam from debug log #26408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently, debug.log is spammed with messages from random.cpp when functional tests are run. These logs are not useful for debugging, and decrease the signal to noise ratio of the logs.
|
ACK ef97b89 |
|
ACK ef97b89, confirmed that this log level is only used in |
|
ACK ef97b89 Confirmed what kouloumos said about this log level only appearing in Applied the code change an observed that the |
theStack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ef97b89
Verified the effect of the PR by running ./test/functional/p2p_segwit.py --nocleanup and comparing debug.log files (on the short-running tests there was no difference). Also checked that the debug messages belonging to the excluded RAND category are indeed not needed for analyzing functional tests.
Warm welcome as a new contributor!
ef97b89 Exclude rand from debug log (Jeff Ruane) Pull request description: Currently, `debug.log` is spammed with messages like this from `random.cpp` when functional tests are run. ``` 2022-10-25T19:24:34.787663Z [scheduler] [random.cpp:519] [SeedPeriodic] [rand] Feeding 36565 bytes of dynamic environment data into RNG ``` These logs are not useful for debugging and decrease the signal-to-noise ratio of the logs, so they should be suppressed by excluding the `rand` category, as the `libevent` and `leveldb` categories currently are. ACKs for top commit: LarryRuane: ACK ef97b89 kouloumos: ACK ef97b89, confirmed that this log level is only used in `random.cpp` and indeed it seems that it doesn't add any value to the debug.log during functional tests. satsie: ACK ef97b89 theStack: ACK ef97b89 Tree-SHA512: 5cea384a3197f0ec77efa9efc77822914450ecf5546606568bbd432c3536040c772c57aef58d3bb083a2e5e756f690766fa1fb382ab1973748db238108a58746
|
Thanks for all the quick feedback, and thanks for the warm welcome @theStack! |
| "-debug", | ||
| "-debugexclude=libevent", | ||
| "-debugexclude=leveldb", | ||
| "-debugexclude=rand", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently,
debug.logis spammed with messages like this fromrandom.cppwhen functional tests are run.These logs are not useful for debugging and decrease the signal-to-noise ratio of the logs, so they should be suppressed by excluding the
randcategory, as thelibeventandleveldbcategories currently are.
Note that the libevent and leveldb categories are external libraries, whereas src/random.{h,cpp} is logging from our own code.
Currently,
debug.logis spammed with messages like this fromrandom.cppwhen functional tests are run.These logs are not useful for debugging and decrease the signal-to-noise ratio of the logs, so they should be suppressed by excluding the
randcategory, as thelibeventandleveldbcategories currently are.