build: remove threadinterrupt from libbitcoinkernel #26360
Conversation
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK afbcd22, tested on Ubuntu 22.04.
FWIW, ./configure --with-experimental-kernel-lib --enable-experimental-util-chainstate && make still works even with the following diff:
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -886,7 +886,6 @@ libbitcoinkernel_la_SOURCES = \
chain.cpp \
chainparamsbase.cpp \
chainparams.cpp \
- clientversion.cpp \
coins.cpp \
compressor.cpp \
consensus/merkle.cpp \
@@ -895,11 +894,9 @@ libbitcoinkernel_la_SOURCES = \
core_read.cpp \
dbwrapper.cpp \
deploymentinfo.cpp \
- deploymentstatus.cpp \
flatfile.cpp \
fs.cpp \
hash.cpp \
- kernel/chain.cpp \
kernel/checks.cpp \
kernel/coinstats.cpp \
kernel/context.cpp \
@@ -932,7 +929,6 @@ libbitcoinkernel_la_SOURCES = \
signet.cpp \
support/cleanse.cpp \
support/lockedpool.cpp \
- sync.cpp \
txdb.cpp \
txmempool.cpp \
uint256.cpp \
That's because you didn't test with |
Correct.
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -886,7 +886,6 @@ libbitcoinkernel_la_SOURCES = \
chain.cpp \
chainparamsbase.cpp \
chainparams.cpp \
- clientversion.cpp \
coins.cpp \
compressor.cpp \
consensus/merkle.cpp \
@@ -895,11 +894,9 @@ libbitcoinkernel_la_SOURCES = \
core_read.cpp \
dbwrapper.cpp \
deploymentinfo.cpp \
- deploymentstatus.cpp \
flatfile.cpp \
fs.cpp \
hash.cpp \
- kernel/chain.cpp \
kernel/checks.cpp \
kernel/coinstats.cpp \
kernel/context.cpp \ |
|
Concept ACK. FWIW, I anticipate threadinterrupt coming back to the kernel eventually as I think we'll want to use it to get rid of I think it's fine to re-add it when it's actually needed though. |
If "works" means compiles, then sure, however this also drops the compile-time deployment status sanity checks from the kernel build. |
afbcd22 build: remove threadinterrupt from libbitcoinkernel (fanquake) Pull request description: Extracted from bitcoin#26292. ACKs for top commit: hebasto: ACK afbcd22, tested on Ubuntu 22.04. ryanofsky: Code review ACK afbcd22 Tree-SHA512: 9d355f0e417561be41cdd0674a8f94c9ffe3ecfb4063bb9c90f1032cb9d471be11d4fa26de40993e3a411e015272201551fbbb3d3c2b43e4c17bf49386a2741c
4 participants
Extracted from #26292.