Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Oct 15, 2022

The old Transifex Command-Line Tool is considered deprecated (as of January 2022) and will sunset on Nov 30, 2022.

See: https://github.com/transifex/cli/blob/devel/README.md#migrating-from-older-versions-of-the-client

An accompanying PR: bitcoin-core/bitcoin-maintainer-tools#142

@hebasto
Copy link
Member Author

hebasto commented Oct 17, 2022

cc @luke-jr @wtogami @jarolrod

@jarolrod
Copy link
Contributor

ACK d6adbb7

This is a necessary change and is correct per the documentation. We have to migrate from a format of <project>.<resource> to o:<org>:p:<proj>:r:<res>. This makes the correct change as it does:

  • o (organization) = bitcoin
  • p (project) = bitcoin
  • r (resource) = qt-translation-024x

@jarolrod
Copy link
Contributor

I should clarify above that this isn't required for 24, and can be backported in 24.1

@maflcko maflcko added the GUI label Oct 18, 2022
@fanquake fanquake merged commit 5974c49 into bitcoin:master Oct 18, 2022
@maflcko maflcko added this to the 24.0 milestone Oct 18, 2022
@hebasto hebasto deleted the 221015-tx branch October 18, 2022 17:42
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 23, 2022
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Oct 28, 2022
@fanquake fanquake mentioned this pull request Oct 28, 2022
@fanquake
Copy link
Member

Backported to 24.x in #26410.

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Oct 28, 2022
@fanquake fanquake mentioned this pull request Oct 28, 2022
@fanquake
Copy link
Member

Backported to 23.x in #26411.

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Oct 28, 2022
@fanquake fanquake mentioned this pull request Oct 28, 2022
@fanquake
Copy link
Member

Backported to 22.x in #26413.

fanquake added a commit that referenced this pull request Oct 31, 2022
d570190 rpc: make `address` field optional (w0xlt)
e4b8c9b rpc: add non-regression test about deriveaddresses crash when index is 2147483647 (muxator)
bf2bf73 rpc: fix crash in deriveaddresses when derivation index is 2147483647 (muxator)
b04f5f9 test: Test for out of bounds vout in sendall (Andrew Chow)
dedee6a wallet: Check utxo prevout index out of bounds in sendall (Andrew Chow)
931db78 test: Test that sendall works with watchonly spending specific utxos (Andrew Chow)
bbe864a wallet: Correctly check ismine for sendall (Andrew Chow)
4b7d30d Adjust `.tx/config` for new Transifex CLI (Hennadii Stepanov)

Pull request description:

  Backports:
  * #26321
  * #26344
  * #26275
  * #26349

ACKs for top commit:
  instagibbs:
    ACK d570190
  hebasto:
    ACK d570190, I've cherry-picked commits manually and got zero diff with this PR branch.

Tree-SHA512: dad64f4074b4f06d666c0f2d804eda92df241bcce0a49c28486311a151f2e9d46b75e1bce02de570dcc85957c9ce936debb2a4faa045800c9757c6c495115d7c
maflcko pushed a commit that referenced this pull request Oct 31, 2022
403de22 rpc: add non-regression test about deriveaddresses crash when index is 2147483647 (muxator)
db20d27 rpc: fix crash in deriveaddresses when derivation index is 2147483647 (muxator)
d174db0 Adjust `.tx/config` for new Transifex CLI (Hennadii Stepanov)

Pull request description:

  Currently backports:
  * #26275
  * #26321

  Will leave open to collect backports for 22.1,

ACKs for top commit:
  MarcoFalke:
    cherry-pick ACK 403de22  🏔

Tree-SHA512: f9095a5cad52ecb9580fcaf173a05148dce382ac773a6116e2aed47009402bdfa6cbce62e488fe96120f7a0a81a623eb3e0e4539fa88670adb8c14cf5e334fa5
maflcko pushed a commit that referenced this pull request Oct 31, 2022
f8ed34d rpc: add non-regression test about deriveaddresses crash when index is 2147483647 (muxator)
d9f1c89 rpc: fix crash in deriveaddresses when derivation index is 2147483647 (muxator)
bbea830 Adjust `.tx/config` for new Transifex CLI (Hennadii Stepanov)

Pull request description:

  Backports:
  * #26275
  * #26321

  Will leave open to collect remaining backports before a 23.1.

ACKs for top commit:
  MarcoFalke:
    cherry-pick ACK f8ed34d  🚝

Tree-SHA512: 2a96f66b0d81457a7017b0f4b041a7742008374d00a22d828502bfe170bfebb413e4e63382b10b9e2e250cb9e1be1a41030b8b6c5be42ffb23964808b12ee343
fanquake added a commit to bitcoin-core/bitcoin-maintainer-tools that referenced this pull request Oct 31, 2022
4dad098 Use new Transifex CLI (Hennadii Stepanov)

Pull request description:

  The old Transifex Command-Line Tool is considered deprecated (as of January 2022) and will sunset on Nov 30, 2022.

  See: transifex/transifex-client#340

  A PR with accompanying changes to `.tx/config`: bitcoin/bitcoin#26321

Top commit has no ACKs.

Tree-SHA512: daab5058a9cc8de9df8bdcb92e818c77304b25f8d606b23def6b8afed4cf295af8192734dd80146d9ee0f449b5fae58c683b6695bab3a6531a5964ee28b114a7
fanquake added a commit to bitcoin-core/gui that referenced this pull request Mar 2, 2023
…mat in Release Process

9c371e5 doc: Update Transifex links and slug format in Release Process (Hennadii Stepanov)

Pull request description:

  Reflected the recent changes in Transifex's [workflow](bitcoin/bitcoin#26321) and on its website.

ACKs for top commit:
  jarolrod:
    ACK 9c371e5

Tree-SHA512: d11f2fa197bba2e3198ca255d80edd7178e8074dc84b03262054d01fa33c8160ca492a1358e9da1e7d32cec21a298593322d10e4cb045ef99ccec2cbe901cb63
@bitcoin bitcoin locked and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants