add lock annotation for FeeFilterRounder::round() #26306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling WITH_LOCK() on a non-recursive mutex requires not holding it beforehand. Co-authored-by: Niklas Gögge <[email protected]>
Member
|
ACK cbb2da8 Works correctly locally, waiting for CI. |
Member
|
ACK cbb2da8 |
Closed
vasild
reviewed
Oct 14, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 23, 2022
cbb2da8 add lock annotation for FeeFilterRounder::round() (glozow) Pull request description: CI failure from bitcoin#24407: https://github.com/bitcoin/bitcoin/runs/8876014446 Calling `WITH_LOCK()` on a non-recursive mutex requires not holding it beforehand. ACKs for top commit: achow101: ACK cbb2da8 dergoegge: ACK cbb2da8 hebasto: ACK cbb2da8, tested on Ubuntu 22.04 with clang 14.0. Tree-SHA512: d6782ee48442b9d64d58a54c1ec7c53822ab051bf9728b44d6a0e05f1953e90f16420d349379345845db203fbad4e1f5750d9070adcb7daa18f12359a29488ca
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI failure from #24407: https://github.com/bitcoin/bitcoin/runs/8876014446
Calling
WITH_LOCK()on a non-recursive mutex requires not holding it beforehand.