build: move util/url to common/url #26294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hmm, going by the other conversations about util vs common, doesn't |
Contributor
|
guix hashes x86: arm64: |
Member
Author
We may ultimately end up moving it there, but I'd rather keep this PR to just adding the adding / consolidating the missing flags (which are touching libs other than common/util), rather than bundling in shuffling too. Happy to discuss / move code in a follow up. |
Member
|
Ok. I was thinking it would make sense to put them in the right place first, but sure, it also makes sense to fix things as-is and ensure consistency before moving. I'm not sure about the need to add |
Member
Same for |
fanquake
changed the title
fanquake
force-pushed
the
cleanup_event_flags
branch
from
44a3fa4 to
934da86
Compare
Member
Author
Doing this now. |
fanquake
force-pushed
the
cleanup_event_flags
branch
from
934da86 to
5589370
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Oct 24, 2022
fanquake
commented
Oct 31, 2022
hebasto
reviewed
Oct 31, 2022
fanquake
force-pushed
the
cleanup_event_flags
branch
from
5589370 to
5b68bd6
Compare
hebasto
reviewed
Oct 31, 2022
The fact that this is missing is currently masked by the inclusion of BOOST_CPPFLAGS.
fanquake
force-pushed
the
cleanup_event_flags
branch
from
5b68bd6 to
3a0b352
Compare
Contributor
|
Fwiw msvc build works for this PR. |
hebasto
approved these changes
Oct 31, 2022
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
Nov 1, 2022
3a0b352 refactor: move url.h/cpp from lib util to lib common (fanquake) 058eb69 build: add missing event cflags to libbitcoin_util (fanquake) Pull request description: Move `util/url` to `common/url`. Also add missing `event_*` flags to `libbitcoin_util`. #26293 + the commit dropping boost cppflags from `libbitcoin_util` shows this issue. i.e: ```bash CXX util/libbitcoin_util_a-url.o util/url.cpp:7:10: fatal error: 'event2/http.h' file not found #include <event2/http.h> ^~~~~~~~~~~~~~~ 1 error generated. ``` ACKs for top commit: hebasto: ACK 3a0b352 ryanofsky: Code review ACK 3a0b352 Tree-SHA512: 600a76fd334267a02d332df9b67891a38d3fd7f5baf8a82b2447879b3bc65eab2552d2c081c0a5f1ec927bf80df7fc1f0cbbdda4cb76994b46dadf260b8e1cb3
Member
Author
|
This has been merged. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
util/urltocommon/url.Also add missing
event_*flags tolibbitcoin_util. #26293 + the commit dropping boost cppflags fromlibbitcoin_utilshows this issue. i.e: