Skip to content

ci: Allow PIP_PACKAGES on centos #26234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 2 commits into from
Oct 4, 2022
Merged

ci: Allow PIP_PACKAGES on centos #26234

fanquake merged 2 commits into from
Oct 4, 2022

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Oct 3, 2022 •
edited
Loading

This was added in 7fc5e86 but I can't see a reason why this should be forbidden.

This is also needed for other changes (bumping the minimum python version).

@DrahtBot DrahtBot added the Tests label Oct 3, 2022
hebasto
hebasto reviewed Oct 3, 2022
View reviewed changes
maflcko
maflcko commented Oct 3, 2022
View reviewed changes
ci/test/04_install.sh Outdated
Copy link
Member Author

@maflcko maflcko Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review note: Adding CI_EXEC is required, otherwise it would result in a failure.

To reproduce the failure:

$ RESTART_CI_DOCKER_BEFORE_RUN=1 FILE_ENV="./ci/test/00_setup_env_i686_centos.sh" ./ci/test_run_all.sh
...
bash: line 1: pip3: command not found

Copy link
Member Author

@maflcko maflcko Oct 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also fixes a bug on historic commits. To reproduce the bug on the historic commits:

$ git checkout 3c3bd9022026a75e15492ba9cf8bf3b72866b9a9~ && RESTART_CI_DOCKER_BEFORE_RUN=1 FILE_ENV="./ci/test/00_setup_env_i686_multiprocess.sh" ./ci/test_run_all.sh
...
bash: line 1: pip3: command not found

hebasto
hebasto approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa684bcde97e7ed5de102429e1e656c6d091a547, I have reviewed the code and it looks OK, I agree it can be merged.

@maflcko
Copy link
Member Author

maflcko commented Oct 3, 2022

cc @fanquake (author of 7fc5e86)

@maflcko maflcko requested a review from fanquake October 3, 2022 12:48
fanquake
fanquake approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa684bcde97e7ed5de102429e1e656c6d091a547 - I see lief still being installed.

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 3, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #26226 (Bump minimum python version to 3.7 by MarcoFalke)
  • #25900 (ci: run docker wrapper with a non-root user by josibake)
  • #24798 ([POC] build: Hello Qt 6 by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request Oct 3, 2022
Merged
maflcko
maflcko commented Oct 4, 2022
View reviewed changes
@maflcko
Copy link
Member Author

maflcko commented Oct 4, 2022

For reference, interface_zmq.py:

hebasto
hebasto approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK fa6054e

@fanquake fanquake merged commit a23f8c8 into bitcoin:master Oct 4, 2022
@DrahtBot DrahtBot mentioned this pull request Oct 4, 2022
Merged
@maflcko maflcko deleted the 2210-centos-pip-🏣 branch October 5, 2022 08:57
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 5, 2022
@fanquake
Merge bitcoin#26234: ci: Allow PIP_PACKAGES on centos
cb725b6
@fanquake fanquake mentioned this pull request Jan 12, 2023
Merged
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jan 12, 2023
ci: Remove unused package
644c030 
Address feedback from https://github.com/bitcoin/bitcoin/pull/24561/files#r985719812

Github-Pull: bitcoin#26234
Rebased-From: fac085a
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jan 12, 2023
ci: Allow PIP_PACKAGES on centos
ce2a072 
This was added in 7fc5e86 but I can't
see a reason why this should be forbidden.

Github-Pull: bitcoin#26234
Rebased-From: fa6054e
@maflcko maflcko mentioned this pull request Jan 12, 2023
Merged
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 12, 2023
@hebasto @fanquake
ci: Use macos-ventura-xcode:14.1 image for "macOS native" task
46d99d5 
Github-Pull: bitcoin#26234
Rebased-From: da16893
jarolrod pushed a commit to jarolrod/bitcoin that referenced this pull request Jan 13, 2023
@hebasto @jarolrod
ci: Use macos-ventura-xcode:14.1 image for "macOS native" task
4ee5dbe 
Github-Pull: bitcoin#26234
Rebased-From: da16893
@bitcoin bitcoin locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanquake fanquake fanquake approved these changes

@hebasto hebasto hebasto approved these changes

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maflcko @DrahtBot @fanquake @hebasto