refactor: move Boost Datetime usage to wallet #26198
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
aureleoules
left a comment
aureleoules
left a comment
There was a problem hiding this comment.
ACK aec34489854198908424b6ef61142315533fd074
Could it be enforced to avoid reintroducing by accident in the future? |
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK aec34489854198908424b6ef61142315533fd074, I have reviewed the code and it looks OK, I agree it can be merged.
|
Concept ACK. |
|
ACK aec34489854198908424b6ef61142315533fd074. Agree with @hebasto's comment to avoid losing some test coverage. Nice to relegate this to wallet only. |
This means we don't need datetime in a --disable-wallet build, and it isn't included in the kernel.
fanquake
force-pushed
the
move_wallet_boost_out
branch
from
aec3448 to
079cf88
Compare
aureleoules
left a comment
aureleoules
left a comment
There was a problem hiding this comment.
re-ACK 079cf88 - rebased and two additional unit tests since my last review.
|
This is reverting 9e2c623, but seems fine if the goal is to remove boost from kernel? |
Yes, and removing it from bitcoind+utils more generally. There's no reason for this wallet-only Boost usage to be sucked into everything else. |
|
Right, I can't see a use case to parse this outside of the wallet, so lgtm |
7 participants
This means we don't need Boost Datetime in a
--disable-walletbuild, and it isn't included in the kernel (via time.h/cpp). Split from a larger boost removal branch/effort.