Use PACKAGE_NAME in messages rather than hardcoding "Bitcoin Core"
#26142
Conversation
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
This doesn't work as is
Thanks! Updated. |
hebasto
force-pushed
the
220920-package
branch
from
392d8e3 to
d895eb2
Compare
src/init.cpp
Outdated
| return strprintf(_("%s request to listen on port %u. This port is considered \"bad\" and " | ||
| "thus it is unlikely that any Bitcoin Core peers connect to it. See " | ||
| return strprintf(_("%s requests to listen on port %u. This port is considered \"bad\" and " | ||
| "thus it is unlikely that any %s peers connect to it. See " |
There was a problem hiding this comment.
| "thus it is unlikely that any %s peers connect to it. See " | |
| "thus it is unlikely that any peers will connect to it. See " |
No reason to name the software specifically here?
There was a problem hiding this comment.
On second thought, we are touching this, but it isn’t a part of the pr’s goal to address something like this; seems appropriate for a follow-up if someone wants to suggest this change.
There was a problem hiding this comment.
No reason to name the software specifically here?
| <widget class="QLineEdit" name="externalSignerPath"> | ||
| <property name="toolTip"> | ||
| <string>Full path to a Bitcoin Core compatible script (e.g. C:\Downloads\hwi.exe or /Users/you/Downloads/hwi.py). Beware: malware can steal your coins!</string> | ||
| <string>Full path to a %1 compatible script (e.g. C:\Downloads\hwi.exe or /Users/you/Downloads/hwi.py). Beware: malware can steal your coins!</string> |
|
|
||
| #ifndef ENABLE_EXTERNAL_SIGNER | ||
| #ifdef ENABLE_EXTERNAL_SIGNER | ||
| ui->externalSignerPath->setToolTip(ui->externalSignerPath->toolTip().arg(PACKAGE_NAME)); |
There was a problem hiding this comment.
Might be nice if there was a BIP we could specify here...
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
hebasto
force-pushed
the
220920-package
branch
from
d895eb2 to
b147322
Compare
|
Updated d895eb2 -> b147322 (pr26142.02 -> pr26142.03, diff):
|
|
Friendly ping @jarolrod. |
6 participants
Usually, we do not hardcode "Bitcoin Core" in the user-faced messages.
See:
Also grammar has been improved -- singular instead of plural.