build: remove strings.h from header checks #26135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't include strings.h anywhere. This is also already checked for by autoconf, so us checking for it just means a 3rd existence check during ./configure.
hebasto
approved these changes
Sep 21, 2022
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK eb6026b, tested on macOS 12.6:
- on master 80d1598:
% ./autogen.sh
% ./configure 2>&1 | grep -e 'strings.h'
checking for strings.h... yes
checking for strings.h... (cached) yes
checking for strings.h... yes
- with this PR:
% ./autogen.sh
% ./configure 2>&1 | grep -e 'strings.h'
checking for strings.h... yes
checking for strings.h... yes
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 23, 2022
eb6026b build: remove strings.h from header checks (fanquake) Pull request description: We don't include `strings.h` anywhere. This is also already checked for by autoconf, so us checking for it just means a 3rd existence check during `./configure`. ACKs for top commit: TheCharlatan: Code review ACK eb6026b hebasto: ACK eb6026b, tested on macOS 12.6: Tree-SHA512: 4036c21b2f659140e9f471b4d24336fe925c6c010e2ced36e1f606d9c76dea236d086d15a884eb8f95381b39322abeecab973b10532527005fdadd095411e358
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't include
strings.hanywhere.This is also already checked for by autoconf, so us checking for it just means a 3rd existence check during
./configure.