build: remove unused cppflags #26089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ACK 557ed5973329052418ad371ebc43a74ac8096f1b. Confirmed that mapport.cpp is the only user of these includes. From a quick glance it looks like these two shouldn't require libevent either though? |
Member
|
Concept ACK.
That is true at least for |
Their inclusion is likely just the result of copy-paste. The only place upnp/natpmpflags should be used is `libbitcoin_node` (mapport.cpp).
fanquake
changed the title
fanquake
force-pushed
the
prune_unneeded_upnp_natpmp
branch
from
557ed59 to
4b656b9
Compare
Member
Author
Looks like it. Have added a commit to drop them as well. |
theuni
approved these changes
Sep 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Their inclusion is likely just the result of copy-paste.
The only place upnp & natpmp CPPFLAGS should be used is
libbitcoin_node(mapport.cpp).