Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Sep 13, 2022

As #26056 fixes #25947 it looks reasonable to revert #21988.

@hebasto hebasto added the macOS label Sep 13, 2022
@jarolrod
Copy link
Contributor

concept ack

@fanquake
Copy link
Member

ACK - post rebase

@hebasto
Copy link
Member Author

hebasto commented Sep 14, 2022

Rebased b7f1d2f -> 34a2f91 (pr26079.01 -> pr26079.02) on top of the merged #26056.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 34a2f91 - haven't tested at all.

@fanquake fanquake added this to the 24.0 milestone Sep 14, 2022
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 34a2f91

Confirming that this is no longer an issue. Tested on both an M1 and intel mac

@fanquake fanquake merged commit c67d6f5 into bitcoin:master Sep 14, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 14, 2022
…supported"

34a2f91 Revert "doc: note that brew installed qt is not supported" (Hennadii Stepanov)

Pull request description:

  As bitcoin#26056 fixes bitcoin#25947 it looks reasonable to revert bitcoin#21988.

ACKs for top commit:
  fanquake:
    ACK 34a2f91 - haven't tested at all.
  jarolrod:
    ACK bitcoin@34a2f91

Tree-SHA512: 4470f21fb6ea32970d7572c83ba064bcbe6e3282cea79122312f8ac203a5b1617b21952db1d6e47ba5b6f605abc23f72c04c07cef7251272e22fb593ff317beb
@hebasto hebasto deleted the 220913-brew branch September 14, 2022 19:02
@bitcoin bitcoin locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MacOS Build Error: Qt 5 and 6 Simultaneously Installed.

3 participants