Skip to content

Conversation

@furszy
Copy link
Member

@furszy furszy commented Aug 18, 2022

Fixing #25734 (comment) -> https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=50329

The OUTPUT_TYPES array contain the known active output types only.
And it's solely used to create/walk-through the active spkms.

So, no need to add the UNKNOWN type here.

This array contains the known active output types only.
And it's solely used to create/walk-through the active spkms.
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #24897 ([Draft / POC] Silent Payments by w0xlt)
  • #23417 (wallet, spkm: Move key management from DescriptorScriptPubKeyMan to wallet level KeyManager by achow101)
  • #22341 (rpc: add getxpub by Sjors)
  • #19602 (wallet: Migrate legacy wallets to descriptor wallets by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Contributor

@w0xlt w0xlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5b4fdbb

Copy link
Contributor

@LarryRuane LarryRuane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5b4fdbb

@achow101
Copy link
Member

ACK 5b4fdbb

@achow101 achow101 merged commit 0f0508b into bitcoin:master Aug 19, 2022
@furszy furszy deleted the 2022_fix_output_type_fuzz branch May 27, 2023 01:47
@bitcoin bitcoin locked and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants