wallet: consolidate CoinSelectionParams::m_change_target and m_min_change_target #25825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values are both intended for the same thing. Their divergence seems to be the result of an incomplete rename.
Member
|
ACK acda7e8 |
furszy
approved these changes
Aug 11, 2022
Member
Author
|
(Credit to @S3RK for pointing this out to me) |
Contributor
|
ACK acda7e8 I'm surprised this didn't get caught by tests. Perhaps we are missing one for the minimum change. My gut feeling is that it wouldn't be trivial to test, so that might be out of scope for this PR, though. |
aureleoules
reviewed
Aug 11, 2022
Contributor
aureleoules
left a comment
aureleoules
left a comment
There was a problem hiding this comment.
ACK acda7e8.
Verified m_change_target is unused and m_min_change_target is the variable that should be used.
Contributor
|
Post merge ACK acda7e8. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values are both intended for the same thing. Their divergence seems to be the result of an incomplete rename.