Skip to content

build: move raw rule into Makefile.am #25813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Aug 10, 2022
Merged

build: move raw rule into Makefile.am #25813

maflcko merged 1 commit into from
Aug 10, 2022

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Aug 10, 2022

The same rule is used by the tests and benchmarks to generate headers,
and currently causes #25501. Just deduplicate the code into Makefile.am.

Fixes: #25501.

@fanquake
build: move raw rule into Makefile.am
d8b26ab 
The same rule is used by the tests and benchmarks to generate headers,
and currently causes bitcoin#25501. Just deduplicate the code into Makefile.am.
hebasto
hebasto approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d8b26ab, tested on Ubuntu 22.04, the moved code was verified using git diff --color-moved=dimmed-zebra HEAD~1..HEAD.

jarolrod
jarolrod approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK d8b26ab

the warning no longer shows for me

@maflcko maflcko merged commit deb7ad3 into bitcoin:master Aug 10, 2022
@jarolrod
Copy link
Contributor

jarolrod commented Aug 10, 2022

guix hashes:

x86:

$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum

fddf1ee490a2d1b30031f146ca40a61142389f2496f0070b49e31edc5d19e942  guix-build-d8b26abed91c/output/aarch64-linux-gnu/SHA256SUMS.part
941396f6ab7ffe9efeb7e71f7193f03955724f1300acce3a1cad594dabc9aba1  guix-build-d8b26abed91c/output/aarch64-linux-gnu/bitcoin-d8b26abed91c-aarch64-linux-gnu-debug.tar.gz
e934fa7e3cbf887e92121637c7ed81aeb906f33e48c7339fef9c2322435302da  guix-build-d8b26abed91c/output/aarch64-linux-gnu/bitcoin-d8b26abed91c-aarch64-linux-gnu.tar.gz
ec73d96dbc5ccd7a725225cf28f3b6f8b440f9ff3322a4b937ea44fe87fa31ae  guix-build-d8b26abed91c/output/arm-linux-gnueabihf/SHA256SUMS.part
b8287038ed02bec923108769c8de3074da7d209791fc963591ea309fd61b757d  guix-build-d8b26abed91c/output/arm-linux-gnueabihf/bitcoin-d8b26abed91c-arm-linux-gnueabihf-debug.tar.gz
f82ac771bdd422964896327dad71e7447577cf12a2f27ebf9f5769e35d3ac245  guix-build-d8b26abed91c/output/arm-linux-gnueabihf/bitcoin-d8b26abed91c-arm-linux-gnueabihf.tar.gz
075d45f7a46c05fb54751760e06397b213a172afb416f40be72dc677b2b73871  guix-build-d8b26abed91c/output/arm64-apple-darwin/SHA256SUMS.part
78040b42246ef7894728c24f36d6475999fe5910722b9e80d4c0bdda7fd4c593  guix-build-d8b26abed91c/output/arm64-apple-darwin/bitcoin-d8b26abed91c-arm64-apple-darwin-unsigned.dmg
02c0833d63e67192dbf9bd8085d1b358233bfc9b736a60091e73f3c337b9b55e  guix-build-d8b26abed91c/output/arm64-apple-darwin/bitcoin-d8b26abed91c-arm64-apple-darwin-unsigned.tar.gz
17ecd9315057ef0f4545148310f5b8074bf8b4cbd2ec6f6328e1743971b49957  guix-build-d8b26abed91c/output/arm64-apple-darwin/bitcoin-d8b26abed91c-arm64-apple-darwin.tar.gz
b1d05c2cbd7ac4138cec71bc4d1290fb34f638600fe282b5b276f048a64f5b4e  guix-build-d8b26abed91c/output/dist-archive/bitcoin-d8b26abed91c.tar.gz
d9c2d04ea47bb242625d898920c706443b61cb75d2091b30ef30ade017044b01  guix-build-d8b26abed91c/output/powerpc64-linux-gnu/SHA256SUMS.part
2cb73db5c190945866a03cf8bacb612cbc431c45935d95f2dad6b034e1e4f1b1  guix-build-d8b26abed91c/output/powerpc64-linux-gnu/bitcoin-d8b26abed91c-powerpc64-linux-gnu-debug.tar.gz
3bb89415c48c2e0ee9d0c7d184742ed358e8c54c459de9a80ad3f68bd7d2b3c2  guix-build-d8b26abed91c/output/powerpc64-linux-gnu/bitcoin-d8b26abed91c-powerpc64-linux-gnu.tar.gz
26835c60a640ada4baf120bf1ba9adb3b4f364d3c1fce573bc6360d3aa51f5de  guix-build-d8b26abed91c/output/powerpc64le-linux-gnu/SHA256SUMS.part
ce707a506bd3807a6ce2172830ba3d809742a6335e4545f062d428f1efbe17d9  guix-build-d8b26abed91c/output/powerpc64le-linux-gnu/bitcoin-d8b26abed91c-powerpc64le-linux-gnu-debug.tar.gz
39e4f75a7266584bca3743c59c0bf0e183d6d351d6688cedd8982eb4a84fbeed  guix-build-d8b26abed91c/output/powerpc64le-linux-gnu/bitcoin-d8b26abed91c-powerpc64le-linux-gnu.tar.gz
3c52189445df0e394dc2a7f2822fc7f300cca0dce9e8f7268b6dfd30aa5a2568  guix-build-d8b26abed91c/output/riscv64-linux-gnu/SHA256SUMS.part
3de86b6ffaa1c69fd959ac2b7e8447bb8a872e9b602ddc4c7ae3146b9fe9bcd2  guix-build-d8b26abed91c/output/riscv64-linux-gnu/bitcoin-d8b26abed91c-riscv64-linux-gnu-debug.tar.gz
d412b5ca465c4aef08c409ccc3059d9b72468000ba65acbf998a93761adf789b  guix-build-d8b26abed91c/output/riscv64-linux-gnu/bitcoin-d8b26abed91c-riscv64-linux-gnu.tar.gz
d9dbe2fec9952afdd8ff8d9e4edf91b61943403169bc80260dff91a905bdb8ca  guix-build-d8b26abed91c/output/x86_64-apple-darwin/SHA256SUMS.part
3a517fe87794eafe22e9db3234a7c29e4431c64292009e75eb56d6159cc4df56  guix-build-d8b26abed91c/output/x86_64-apple-darwin/bitcoin-d8b26abed91c-x86_64-apple-darwin-unsigned.dmg
ed666a8c731553f02f395884800c1dfca55d07a5b2939a632ba4856d201dedc8  guix-build-d8b26abed91c/output/x86_64-apple-darwin/bitcoin-d8b26abed91c-x86_64-apple-darwin-unsigned.tar.gz
34d1962280107a20c6027b18537d60f5b6dbf6c31dfe4ed85b7611bb9647386c  guix-build-d8b26abed91c/output/x86_64-apple-darwin/bitcoin-d8b26abed91c-x86_64-apple-darwin.tar.gz
ce9dfe9e4ed9d81a752dbacdcf4fe6018751a9163bac10f2303c7d4b2c0e3201  guix-build-d8b26abed91c/output/x86_64-linux-gnu/SHA256SUMS.part
6f977b190a604d0e7d637e5bdf0ea0bc47720404b824163a09183662c8f215cf  guix-build-d8b26abed91c/output/x86_64-linux-gnu/bitcoin-d8b26abed91c-x86_64-linux-gnu-debug.tar.gz
5b23ede9ded314b471aa3ca9a3610782fe4700ece6e88d8dc9f7476a9bfed12e  guix-build-d8b26abed91c/output/x86_64-linux-gnu/bitcoin-d8b26abed91c-x86_64-linux-gnu.tar.gz
66b7ef0b9aef983fbedcc7a22feea17ad0a99229f9a80369902bf530a516eb97  guix-build-d8b26abed91c/output/x86_64-w64-mingw32/SHA256SUMS.part
8fe85ed9e8cdb8d600fc2b41f9e17b7f860d0989badb04a3e9e2878a067f32d9  guix-build-d8b26abed91c/output/x86_64-w64-mingw32/bitcoin-d8b26abed91c-win64-debug.zip
6eb229a50c573b68a3eebbc373634de104c102301f7ba80a61a7edaf5285d850  guix-build-d8b26abed91c/output/x86_64-w64-mingw32/bitcoin-d8b26abed91c-win64-setup-unsigned.exe
384d7fd2c001571a8eea8715265f3afdb620cf3df8c364d499473c7ec0e7bd88  guix-build-d8b26abed91c/output/x86_64-w64-mingw32/bitcoin-d8b26abed91c-win64-unsigned.tar.gz
9bc8a40e233c1916f505c520e488124ec05327d4dd05d78669ef0c53764e9dd2  guix-build-d8b26abed91c/output/x86_64-w64-mingw32/bitcoin-d8b26abed91c-win64.zip

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 11, 2022
Merge bitcoin#25813: build: move raw rule into Makefile.am
d5c3eea
@fanquake fanquake deleted the move_raw_h_into_makefile branch August 11, 2022 09:10
@bitcoin bitcoin locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

+1 more reviewer

@jarolrod jarolrod jarolrod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build system

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build: autoconf 2.71 warns that %.raw.h was already defined

4 participants

@fanquake @jarolrod @hebasto @maflcko