psbt: Avoid unsigned int overflow in PSBT_IN_TAP_BIP32_DERIVATION #25812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
approved these changes
Aug 10, 2022
Member
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
utACK befa2a76da4adb5140b4870cd241c38e8ae2e0d0
Member
|
can we catch this in test? |
Member
Author
|
Added a test case. |
achow101
force-pushed
the
psbt-hd-path-int-overflow
branch
from
befa2a7 to
70a55c0
Compare
Member
|
ACK 70a55c0 |
jonatack
reviewed
Aug 10, 2022
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
Review ACK 70a55c0, this should avoid the issue reported in #25749
Error message with the new test, without the code change in psbt.h:
TX decode failed Fee exceeds maximum configured by user (e.g. -maxtxfee, maxfeerate)
Error message with the new test and the code change in psbt.h:
TX decode failed Input Taproot BIP32 keypath has an invalid length
Unrelated: it may be good as a follow-up to add a colon at the end of "TX decode failed" before appending the specific error message.
| for invalid in invalids: | ||
| assert_raises_rpc_error(-22, "TX decode failed", self.nodes[0].decodepsbt, invalid) | ||
| for invalid in invalid_with_msgs: | ||
| psbt, msg = invalid |
Member
There was a problem hiding this comment.
if you retouch
- for invalid in invalid_with_msgs:
- psbt, msg = invalid
+ for psbt, msg in invalid_with_msgs:
Member
|
re-utACK 70a55c0 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 11, 2022
…_BIP32_DERIVATION 70a55c0 psbt: Avoid unsigned int overflow in PSBT_IN_TAP_BIP32_DERIVATION (Andrew Chow) Pull request description: Fixes bitcoin#25749 ACKs for top commit: instagibbs: ACK 70a55c0 darosior: re-utACK 70a55c0 jonatack: Review ACK 70a55c0, this should avoid the issue reported in bitcoin#25749 Tree-SHA512: 6bb58e1cda9a5baa50fcd24f818b5b27ed94f0d33da3f71f6e457618176611bf2a84e1864e9a48d9303c301252bc4c1dee8b19a67dd713e849fb9442851ca341
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25749