test: Target exact weight in MiniWallet _bulk_tx #25773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, replace broad -acceptnonstdtxn=1 with -datacarriersize=100000
theStack
approved these changes
Aug 4, 2022
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Code-review ACK fa2537c
TIL that the Python repetition operator * also accepts negative values and simple yields empty (byte-)strings in that case:
>>> b'a' * -1337
b''
(Intuitively, I would have preferred to keep the first assertion, checking that the target weight is larger than the current tx's weight, in order to prevent a negative dummy_vbytes value, but it doesn't seem to have any negative consequences (no pun intended)🤷♂️ ).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems better to target the exact weight than a weight that is up to more than 2000 WU larger.
Also, replace a broad
-acceptnonstdtxn=1with-datacarriersize=100000to document the test assumptions better.