rpc: add a new parameter desriptor_file to importdescriptors RPC
#25757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
author: Luke Dashjr <[email protected]>
This changes `listdescriptors` to accept `options` parameter but retains compatibility with the previous `private` parameter.
This changes `importdescriptors` to accept `options` parameter but maintains compatibility with the previous `requests` parameter.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 31, 2022
Contributor
Author
|
The commits of this PR were merged into #25747. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new parameter
desriptor_filetoimportdescriptorsRPC, allowing the user to import the descriptors directly from a file.Only the last two commits are new as this PR is built on top of #25747.
With this PR, exporting / importing descriptors and creating watch-only wallet is as simple as:
Without this PR, the user can manually create a file from the
listdescriptorsoutput or usejqto extract thedescriptorfield fromlistdescriptorsbut the idea here is to make things more automated and standardized.And this also opens the way to add the functionality of importing descriptors from files in the GUI,