refactor: Use util::Result class for wallet loading #25722
Draft
+1,321
−737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/25722. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. LLM Linter (✨ experimental)Possible typos and grammar issues:
2025-12-16 |
This was referenced Jul 27, 2022
ryanofsky
force-pushed
the
pr/bresult-load
branch
from
bc4172e to
a09c21c
Compare
ryanofsky
force-pushed
the
pr/bresult-load
branch
from
a09c21c to
e7457d0
Compare
Contributor
Author
-BEGIN VERIFY SCRIPT- git grep -l DatabaseStatus src | xargs sed -i s/DatabaseStatus/DatabaseError/g sed -i '/^ SUCCESS,$/d' src/wallet/db.h -END VERIFY SCRIPT-
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 16, 2025
Add util::Result support for returning warning messages and multiple errors, not just a single error string. This provides a way for functions to report errors and warnings in a standard way, and simplifies interfaces. The functionality is unit tested here, and put to use in followup PR bitcoin#25722
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 16, 2025
Suggested by Martin Leitner-Ankerl <[email protected]> bitcoin#25722 (comment) Co-authored-by: Martin Leitner-Ankerl <[email protected]>
ryanofsky
force-pushed
the
pr/bresult-load
branch
from
d3e677f to
2c7996d
Compare
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. |
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 7, 2026
Add util::Result support for returning warning messages and multiple errors, not just a single error string. This provides a way for functions to report errors and warnings in a standard way, and simplifies interfaces. The functionality is unit tested here, and put to use in followup PR bitcoin#25722
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 7, 2026
Suggested by Martin Leitner-Ankerl <[email protected]> bitcoin#25722 (comment) Co-authored-by: Martin Leitner-Ankerl <[email protected]>
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 7, 2026
Add util::Result support for returning warning messages and multiple errors, not just a single error string. This provides a way for functions to report errors and warnings in a standard way, and simplifies interfaces. The functionality is unit tested here, and put to use in followup PR bitcoin#25722
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 7, 2026
Suggested by Martin Leitner-Ankerl <[email protected]> bitcoin#25722 (comment) Co-authored-by: Martin Leitner-Ankerl <[email protected]>
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 7, 2026
Add util::Result support for returning warning messages and multiple errors, not just a single error string. This provides a way for functions to report errors and warnings in a standard way, and simplifies interfaces. The functionality is unit tested here, and put to use in followup PR bitcoin#25722
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 7, 2026
Suggested by Martin Leitner-Ankerl <[email protected]> bitcoin#25722 (comment) Co-authored-by: Martin Leitner-Ankerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #25665 + #26022. The non-base commits are:
9151b903bfe7Add temporary ResultExtract helper for porting to util::Result6fc7c310918frefactor: Use util::Result class in wallet/sqlite1323422c5ff8refactor: Use util::Result class in wallet/migrate3973473d60berefactor: Use util::Result class in wallet::MakeDatabase6440e70fafd6refactor: Use util::Result class in wallet/dumpd7f3b0ec3284refactor: Use util::Result class in wallet/wallettoolbccb6682eb72refactor: Use util::Result class in wallet/wallet7aa597acc363refactor: Use util::Result class in wallet/load8fb85857a4adrefactor: Use util::Result class in wallet/rpc40fde9a6a71brefactor: Use util::Result class in wallet/interfaces07a929c35a56refactor: Use util::Result class in wallet/test329fa7ad4df5Drop temporary ResultExtract helper for porting to util::Result2c7996d7c398scripted-diff: replace wallet DatabaseStatus with DatabaseErrorWallet loading functions up and down the stack have lots of error and warning parameters, and return error information in different ways. This PR makes them uniformly return
util::Result, without changing behavior.