refactor: Redefine IsSolvable() using descriptors
#25664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 21, 2022
Member
|
ACK 3693771b9aef4e23a1b92b2c52b19ad44dac75da |
furszy
reviewed
Aug 6, 2022
Member
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Needs rebase but ACK 3693771b
Nice that we don't longer need to produce so many dummy signatures. Should get us a pretty decent speedup in AvailableCoins for big wallets.
…DestinationForScript It's already checked by its (only) caller, AddAndGetMultisigDestination.
darosior
force-pushed
the
redefine_issolvable
branch
from
3693771 to
fa3c84d
Compare
Member
Author
|
Rebased. |
furszy
approved these changes
Aug 8, 2022
Member
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Code review ACK fa3c84d8 after rebase.
darosior
force-pushed
the
redefine_issolvable
branch
2 times, most recently
from
40a773a to
fa3c84d
Compare
instagibbs
reviewed
Aug 11, 2022
It was used back when we didn't have a concept of descriptor. Now we can check for solvability using descriptors.
darosior
force-pushed
the
redefine_issolvable
branch
from
fa3c84d to
b16f93c
Compare
Member
|
ACK b16f93c |
Member
|
re-ACK b16f93c |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 11, 2022
b16f93c script/sign: remove needless IsSolvable() utility (Antoine Poinsot) c232ef2 outputtype: remove redundant check for uncompressed keys in AddAndGetDestinationForScript (Antoine Poinsot) Pull request description: Now that we have descriptors there is no need to try to sign for a scriptPubKey using dummy signatures, and using a mocked verification of this witness against the interpreter, just to make sure we know how to spend such a Script. Just try to infer a solvable descriptor: any scriptPubKey that we can sign for can be inferred as such. This came up in bitcoin#24149 but i think it's worth it on its own. ACKs for top commit: instagibbs: ACK bitcoin@b16f93c achow101: re-ACK b16f93c furszy: ACK b16f93c, only change is the `IsSolvable` helper function removal. Tree-SHA512: 137068157ce90210b710b1bf9ac3c400e2ff5af1112f892094b69875ea473d6a899f52adb51e5030cb907dee517602059cd1661107808558efa5de842ba12b41
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have descriptors there is no need to try to sign for a scriptPubKey using dummy signatures, and using a mocked verification of this witness against the interpreter, just to make sure we know how to spend such a Script. Just try to infer a solvable descriptor: any scriptPubKey that we can sign for can be inferred as such.
This came up in #24149 but i think it's worth it on its own.