doc: empty REVIEWERS file #25613
doc: empty REVIEWERS file #25613
Conversation
kristapsk
left a comment
kristapsk
left a comment
There was a problem hiding this comment.
ACK cdbc68c1cd9b8228f8cdee9f61c20639325fb67d. It's kinda CODEOWNERS, don't think Bitcoin Core should have such thing.
|
No strong preference. I usually look at git blame if I feel the need to nag more reviewers. |
|
Yes, However, this list was made for people to opt-in to bot notifications (as it is explained in the first line of the file), but then some people on the list complained about being notified by a bot. 🤷♂️ If there is anyone in this list who prefers those bot notifications, I think we should keep them in this list and remove everyone else. |
|
Currently, the format of the comment looks like this: #25614 (comment) This may be interesting to people that are not subscribed to the repo, but want to subscribe to changes to a specific file or folder. My suggestion would be to keep the file and remove all contents for now, then leave the pull open for two weeks before merge. In those two weeks, people can explicitly opt-in by leaving a comment to be (re-)added to the file with the understanding that they will receive some kind of bot notifications. Also, anyone can open a pull request in the future to opt-in. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Should we wait any longer? |
|
I'd also say to keep the empty file in the repo for another two months to give people a chance to add themselves (opt-in to notifications) if they want. |
It seems that it's time for our experiment with this file to come to an end. See discussion here: https://github.com/bitcoin/bitcoin/pull/25560/files#r915491743.
fanquake
force-pushed
the
remove_reviewers
branch
from
cdbc68c to
4d06fc4
Compare
Pushed to just empty the file. |
|
ACK 4d06fc4 seems best to have devs opt-in to this explicitly by themselves |
ghost
mentioned this pull request
5 participants
It seems that it's time for our experiment with this file to come to an
end.
See discussion here:
https://github.com/bitcoin/bitcoin/pull/25560/files#r915491743.