Skip to content

added bitcoin-qt manpage and corrected a few minus signs #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 2 commits into from
Apr 27, 2013
Merged

added bitcoin-qt manpage and corrected a few minus signs #2559

laanwj merged 2 commits into from
Apr 27, 2013

Conversation

@maqifrnswa
Copy link
Contributor

@maqifrnswa maqifrnswa commented Apr 24, 2013

Added a missing manpage and corrected some minus signs that were used as hyphens.

@gavinandresen
Copy link
Contributor

gavinandresen commented Apr 24, 2013

ACK

sipa
sipa reviewed Apr 24, 2013
View reviewed changes
contrib/debian/manpages/bitcoin.conf.5 Outdated
Copy link
Member

@sipa sipa Apr 24, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: capitalisation of Do

Copy link
Member

@laanwj laanwj Apr 24, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't IRC support (and thus, the noirc option) removed some time ago?

Copy link
Member

@sipa sipa Apr 24, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, yes it seems this page is not based on git head's code.

Copy link
Contributor Author

@maqifrnswa maqifrnswa Apr 24, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right - this line should be dropped. the bitcoin-qt manpage was made using help2man on bitcoin-qt 0.8.1 so it doesn't mention irc. This line was pulled in from an old bitcoin.conf manpage

@laanwj
Copy link
Member

laanwj commented Apr 26, 2013

ACK

@BitcoinPullTester
Copy link

BitcoinPullTester commented Apr 26, 2013

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ab20cd76f20893efb155ed4314312849afc60a7f for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

laanwj added a commit that referenced this pull request Apr 27, 2013
@laanwj
Merge pull request #2559 from maqifrnswa/manpages
6e40d79 
added bitcoin-qt manpage and corrected a few minus signs
@laanwj laanwj merged commit 6e40d79 into bitcoin:master Apr 27, 2013
@maqifrnswa maqifrnswa deleted the manpages branch February 24, 2014 15:31
laudney pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this pull request Mar 19, 2014
@laanwj
Merge pull request bitcoin#2559 from maqifrnswa/manpages
0be5167 
added bitcoin-qt manpage and corrected a few minus signs
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maqifrnswa @gavinandresen @laanwj @BitcoinPullTester @sipa