wallet: cleanup cached amount and input mine check code #25543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
aureleoules
reviewed
Jul 6, 2022
src/wallet/test/wallet_tests.cpp
Outdated
Contributor
There was a problem hiding this comment.
nit
Suggested change
| BOOST_CHECK_EQUAL(CachedTxGetImmatureCredit(wallet, wtx, ISMINE_SPENDABLE), 50*COIN); | |
| BOOST_CHECK_EQUAL(CachedTxGetImmatureCredit(wallet, wtx, ISMINE_SPENDABLE), 50 * COIN); |
aureleoules
reviewed
Jul 6, 2022
Contributor
aureleoules
left a comment
aureleoules
left a comment
There was a problem hiding this comment.
ACK ba2fa8302dc3816d5b9584907135f91789846d65.
Looks better!
I checked that the refactor does not change the behavior of the code.
theStack
approved these changes
Jul 6, 2022
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Code-review ACK ba2fa8302dc3816d5b9584907135f91789846d65
Nice refactoring!
jonatack
reviewed
Jul 6, 2022
Instead of duplicate the exact same code twice.
furszy
force-pushed
the
2022_wallet_cleanup_1
branch
from
ba2fa83 to
47ea70f
Compare
Member
Author
|
per feedback, have inlined |
theStack
approved these changes
Jul 7, 2022
Member
Author
|
hey @jonatack @aureleoules, friendly ping here. |
Contributor
|
re-ACK 47ea70f |
Member
|
ACK 47ea70f |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 21, 2022
…ck code 47ea70f wallet: clean AllInputsMine code, use InputIsMine internally (furszy) bf310b0 wallet: clean InputIsMine code, use GetWalletTx (furszy) 0cb1772 wallet: unify CachedTxGetImmatureCredit and CachedTxGetImmatureWatchOnlyCredit (furszy) 04c6423 wallet: remove always true 'fUseCache' arg from CachedTxGetAvailableCredit (furszy) 4f0ca9b wallet: remove always false 'recalculate' arg from GetCachableAmount (furszy) 47b1012 wallet: remove always true 'fUseCache' from CachedTxGetImmatureWatchOnlyCredit (furszy) da8f62d wallet: remove always true 'fUseCache' from CachedTxGetImmatureCredit (furszy) Pull request description: Another wallet's code garbage collector work. Part of the `mapWallet` encapsulation goal. Focused on the following points: 1) Remove always true `fUseCache` argument from `CachedTxGetImmatureCredit`, `CachedTxGetImmatureWatchOnly` and `CachedTxGetAvailableCredit`. 2) Remove always false `recalculate` argument from `GetCachableAmount`. 3) Merge `CachedTxGetImmatureCredit` and `CachedTxGetImmatureWatchOnlyCredit` as they do share the exact same code. 4) Clean `InputIsMine` method; use `GetWalletTx` instead of access the wallet's map directly. 5) Clean `AllInputsMine` method; use `InputIsMine` instead of duplicate the exact same code internally. ACKs for top commit: aureleoules: re-ACK 47ea70f achow101: ACK 47ea70f theStack: re-ACK 47ea70f Tree-SHA512: e9b64b57de7be6165c5e5552e28cd8a03d4736b0a3707d29d129e3a0a3db6a855c2abf47a24917236060835a297b564a97b66d4c8b178d6bdafb93a12a7c0b40
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another wallet's code garbage collector work. Part of the
mapWalletencapsulation goal.Focused on the following points:
fUseCacheargument fromCachedTxGetImmatureCredit,CachedTxGetImmatureWatchOnlyandCachedTxGetAvailableCredit.recalculateargument fromGetCachableAmount.CachedTxGetImmatureCreditandCachedTxGetImmatureWatchOnlyCreditas they do share the exact same code.InputIsMinemethod; useGetWalletTxinstead of access the wallet's map directly.AllInputsMinemethod; useInputIsMineinstead of duplicate the exact same code internally.