wallet: fix warning: "argument name 'feerate' in comment does not match parameter name" #25410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thoughts on flipping this around, to properly document the args?: return AvailableCoins(wallet, coinControl,
/*feerate=*/ std::nullopt,
/*nMinimumAmount=*/ 1,
/*nMaximumAmount=*/ MAX_MONEY,
/*nMinimumSumAmount=*/ MAX_MONEY,
/*nMaximumCount=*/ 0
).total_amount; |
…ch parameter name" Happened because the "feerate=" comment was after the comma.
furszy
force-pushed
the
2022_wallet_25005_follow-up
branch
from
97b680a to
7ca8726
Compare
Member
Author
Flipped 👍🏼 |
Empact
reviewed
Jun 18, 2022
| /*nMinimumAmount=*/ 1, | ||
| /*nMaximumAmount=*/ MAX_MONEY, | ||
| /*nMinimumSumAmount=*/ MAX_MONEY, | ||
| /*nMaximumCount=*/ 0 |
Contributor
There was a problem hiding this comment.
nit: could de-dent this to the standard 4 spaces
Contributor
|
Code Review ACK 7ca8726 |
Contributor
|
Post-merge ACK 7ca8726 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve the tiny #25005 (comment).
Which merely happens for the extra "=" character after the comma.