doc: Update importaddress mention incompatibility with descriptor wallet #25368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK |
theStack
reviewed
Jun 14, 2022
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Concept ACK
Note that in general the tests should pass at each commit, i.e. error message changes and test adaptions should be part of the same commit.
Contributor
Author
Sorry about that I didn't know. Let me know if I should fix it. |
Member
|
Please squash your commits so that the tests change when the errors change. |
brokenprogrammer
force-pushed
the
importaddress-descriptor-wallet-documentation
branch
from
3c7d278 to
ff1c255
Compare
brokenprogrammer
force-pushed
the
importaddress-descriptor-wallet-documentation
branch
from
ff1c255 to
e3609cd
Compare
Contributor
Author
Done! Also noticed a missing space after |
laanwj
reviewed
Jun 15, 2022
| assert_raises_rpc_error(-4, "This type of wallet does not support this command", recv_wrpc.rpc.dumpwallet, 'wallet.dump') | ||
| assert_raises_rpc_error(-4, "This type of wallet does not support this command", recv_wrpc.rpc.importwallet, 'wallet.dump') | ||
| assert_raises_rpc_error(-4, "This type of wallet does not support this command", recv_wrpc.rpc.sethdseed) | ||
| assert_raises_rpc_error(-4, "Only legacy wallets are supported by this command", recv_wrpc.rpc.importprivkey, "cVpF924EspNh8KjYsfhgY96mmxvT6DgdWiTYMtMjuM74hJaU5psW") |
Member
There was a problem hiding this comment.
Some of these other RPCs could use porting documentation too (not in this PR, but may keep #25363 open and rename it).
Member
|
Code review ACK e3609cd |
Member
|
ACK e3609cd |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 15, 2022
…y with descriptor wallet e3609cd doc: Update importaddress mention incompatibility with descriptor wallet (BrokenProgrammer) Pull request description: This is related to bitcoin#25363 and offers a small update to the error messages from `EnsureLegacyScriptPubKeyMan` and `EnsureConstLegacyScriptPubKeyMan` to mention that they only are compatible with legacy wallets. The RPC documentation for `importaddress` is also updated to mention this as well as guide the user to the alternative `importdescriptors` for cases when using descriptor wallets. I'm thinking that we can introduce a "porting guide" document mentioned in bitcoin#25363 in a separate PR since I would have to make myself more familiar with the subject before being able to tackle that. ACKs for top commit: laanwj: Code review ACK e3609cd achow101: ACK e3609cd Tree-SHA512: c7a924a7283fe59dc4e04c8c8fa034c15601f0b25eff09d975e98e2e8db5268ff470336b2d978d6916af9f782f9257b840d64bd15485b1742b4a8b8bfd0bb50f
JOHNJOHN2133
added a commit
to JOHNJOHN2133/gui
that referenced
this pull request
Jul 24, 2022
<!DOCTYPE html>
<html lang="en" class="skip-scroll-target-into-view js-skip-scroll-target-into-view"data-color-mode="auto" data-light-theme="light" data-dark-theme="dark" data-a11y-animated-images="system">
<head>
<meta charset="utf-8">
<link rel="dns-prefetch" href="https://github.githubassets.com">
<link rel="dns-prefetch" href="https://avatars.githubusercontent.com">
<link rel="dns-prefetch" href="https://github-cloud.s3.amazonaws.com">
<link rel="dns-prefetch" href="https://user-images.githubusercontent.com/">
<link rel="preconnect" href="https://github.githubassets.com" crossorigin>
<link rel="preconnect" href="https://avatars.githubusercontent.com">
<link crossorigin="anonymous" media="all" integrity="sha512-ksfTgQOOnE+FFXf+yNfVjKSlEckJAdufFIYGK7ZjRhWcZgzAGcmZqqArTgMLpu90FwthqcCX4ldDgKXbmVMeuQ==" rel="stylesheet" href="https://github.githubassets.com/assets/light-92c7d381038e.css" /><link crossorigin="anonymous" media="all" integrity="sha512-1KkMNn8M/al/dtzBLupRwkIOgnA9MWkm8oxS+solP87jByEvY/g4BmoxLihRogKcX1obPnf4Yp7dI0ZTWO+ljg==" rel="stylesheet" href="https://github.githubassets.com/assets/dark-d4a90c367f0c.css" /><link data-color-theme="dark_dimmed" crossorigin="anonymous" media="all" integrity="sha512-cZa7DZqvMBwD236uzEunO/G1dvw8/QftyT2UtLWKQFEy0z0eq0R5WPwqVME+3NSZG1YaLJAaIqtU+m0zWf/6SQ==" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_dimmed-7196bb0d9aaf.css" /><link data-color-theme="dark_high_contrast" crossorigin="anonymous" media="all" integrity="sha512-WVoKqJ4y1nLsdNH4RkRT5qrM9+n9RFe1RHSiTnQkBf5TSZkJEc9GpLpTIS7T15EQaUQBJ8BwmKvwFPVqfpTEIQ==" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_high_contrast-595a0aa89e32.css" /><link data-color-theme="dark_colorblind" crossorigin="anonymous" media="all" integrity="sha512-XpAMBMSRZ6RTXgepS8LjKiOeNK3BilRbv8qEiA/M3m+Q4GoqxtHedOI5BAZRikCzfBL4KWYvVzYZSZ8Gp/UnUg==" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_colorblind-5e900c04c491.css" /><link data-color-theme="light_colorblind" crossorigin="anonymous" media="all" integrity="sha512-3HF2HZ4LgEIQm77yOzoeR20CX1n2cUQlcywscqF4s+5iplolajiHV7E5ranBwkX65jN9TNciHEVSYebQ+8xxEw==" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_colorblind-dc71761d9e0b.css" /><link data-color-theme="light_high_contrast" crossorigin="anonymous" media="all" integrity="sha512-+J8j3T0kbK9/sL3zbkCfPtgYcRD4qQfRbT6xnfOrOTjvz4zhr0M7AXPuE642PpaxGhHs1t77cTtieW9hI2K6Gw==" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_high_contrast-f89f23dd3d24.css" /><link data-color-theme="light_tritanopia" crossorigin="anonymous" media="all" integrity="sha512-AQeAx5wHQAXNf0DmkvVlHYwA3f6BkxunWTI0GGaRN57GqD+H9tW8RKIKlopLS0qGaC54seFsPc601GDlqIuuHg==" rel="stylesheet" data-href="https://github.githubassets.com/assets/light_tritanopia-010780c79c07.css" /><link data-color-theme="dark_tritanopia" crossorigin="anonymous" media="all" integrity="sha512-+u5pmgAE0T03d/yI6Ha0NWwz6Pk0W6S6WEfIt8veDVdK8NTjcMbZmQB9XUCkDlrBoAKkABva8HuGJ+SzEpV1Uw==" rel="stylesheet" data-href="https://github.githubassets.com/assets/dark_tritanopia-faee699a0004.css" />
<link crossorigin="anonymous" media="all" integrity="sha512-Zl0JBY0YhK6Oj7VqevEvUpzx9Ul3Sr09pIuarzaSkw5sV5vON40vgM9iwBvOKhZSnFmFb+9i9ie+IremL2qc7w==" rel="stylesheet" href="https://github.githubassets.com/assets/primer-665d09058d18.css" />
<link crossorigin="anonymous" media="all" integrity="sha512-70eqNxCylN5NZBpkXmCAACYDfcIjsmZkHUeuW4G7eN6l83VpD4aceELPIHPbqR0el7doWT/ffKKwnqWlJ56tmw==" rel="stylesheet" href="https://github.githubassets.com/assets/global-ef47aa3710b2.css" />
<link crossorigin="anonymous" media="all" integrity="sha512-/uFXblvSX+c7XWJtxcsRArU0ijMp908BQQfQhqxtdWEgDaoARBewXfmkigufl0c4eY6j6vcra6qgoup4Ad9RNg==" rel="stylesheet" href="https://github.githubassets.com/assets/github-fee1576e5bd2.css" />
<link crossorigin="anonymous" media="all" integrity="sha512-PXtwH8brj9qH7LskWA0iAMLw4Wx3RXN7txSxjlqdzQEalZKu3UcsQ+ajfHJMDkYDA2iWL1FIrf2zyLflA5Xu7A==" rel="stylesheet" href="https://github.githubassets.com/assets/code-3d7b701fc6eb.css" />
<link crossorigin="anonymous" media="all" integrity="sha512-11ic8A3gPwHuOH9L4GR9DzEk7grfO6COEtu8DL67r/Fa79Eejva2PyixQ7IB7s1NIk7DX+YT/6bQIRhhNqEPrQ==" rel="stylesheet" href="https://github.githubassets.com/assets/pull-requests-d7589cf00de0.css" />
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-vbn8xBNgs2GKGFAGP+T/OjeI85hn7s1B+8GYeqYX1v40276p+IokO1DU+9wrNDk4ygwMqYBMbcBbPpl6+i7OLA==" src="https://github.githubassets.com/assets/runtime-bdb9fcc41360.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-ZTbn+sr25xFwrZOStm85eDk68/lijDt9/y+CTAU4aQFp8uLFWRcTaRJ/baafzT7KjfYffJmGoAzSzxIcDLFnUA==" src="https://github.githubassets.com/assets/vendors-node_modules_manuelpuyol_turbo_dist_turbo_es2017-esm_js-6536e7facaf6.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-C/i5ePqFPmIDtXzu89SC+gootD5m5WbIv7Dc5DfDctwyq0Z4JMTw3/fDjC3zEh3yT4hzCDTdnrVTdsWIm85hYA==" src="https://github.githubassets.com/assets/vendors-node_modules_stacktrace-parser_dist_stack-trace-parser_esm_js-node_modules_github_bro-a4c183-0bf8b978fa85.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-bflErfRTU+mM6GITg4JpDSjbEtCZy9fLjZM9YmOFdNlkX6zRwnd343PUoYCosr5/pRnwBjPegM4tqTxUM4TCZg==" src="https://github.githubassets.com/assets/environment-6df944adf453.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-xigrvjySI1YRktJT463ayw7nEkpyrKhUB2Ykz9Ol+0jgMf9U0D05QznY+SHClkq1Qno/lEaEogoqgxrE8YWxIg==" src="https://github.githubassets.com/assets/vendors-node_modules_selector-observer_dist_index_esm_js-c6282bbe3c92.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-dM41iRQ6UnYpR76C4HgAkHjucNGjvYIYdaiHRHJjnUho6/BQSDwR0y3+Bn3I+8Tzf9um6aZvv8Okz6+Rc1s+fA==" src="https://github.githubassets.com/assets/vendors-node_modules_delegated-events_dist_index_js-node_modules_github_details-dialog-elemen-63debe-74ce3589143a.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-9pW7JhRe9IQVydCTHOpvwGjSb/Jv0VMgw4ywixLfvcRyWAluZ6YNxeaFwrRJFwzpVjl4U5k39qD2Tp0AQI5aSQ==" src="https://github.githubassets.com/assets/vendors-node_modules_fzy_js_index_js-node_modules_github_catalyst_lib_index_js-f695bb26145e.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-OPW0eYJnfr/CCZWLfMgMkyxXEusD3kDJScVUdRux0+7KYf8K8VszVyPA1G+EgVoQ3blaZZ3+EZexd/jr5AdibQ==" src="https://github.githubassets.com/assets/vendors-node_modules_github_filter-input-element_dist_index_js-node_modules_github_remote-inp-73b750-38f5b4798267.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-8r8MRFPdPm6/fQi/0vunbUg3ivkWwbehhLhJCD/qdcCz30GDYMaGg9p97qyCEiVL0uM1UVOqNJgmSZ4jqXfneA==" src="https://github.githubassets.com/assets/vendors-node_modules_github_time-elements_dist_index_js-f2bf0c4453dd.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-0WsQ2vrE54CLPIG0e8JPikY6twbI76udEwpvn0QxFYKBZ8nNxhAZm/4XuFy7IwZ4vJGYC6qFWhR1+3KRQPpgLA==" src="https://github.githubassets.com/assets/vendors-node_modules_github_file-attachment-element_dist_index_js-node_modules_primer_view-co-54af05-d16b10dafac4.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-VP9EGoy+HDZpdl6AmeFeqvnZQ/IGp1LlKjXr4T2EWa5Hbj6jXjC4hYe5ulssN6Z77iW6oXhwauuNfJdIia0qfA==" src="https://github.githubassets.com/assets/github-elements-54ff441a8cbe.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-HqjjlypEGKA5bnESTEmZ+Za6kAKkp17dLQhs/djwFWldsr5MgCNpiwX3I2hJnuPeez71QrmgUyLfuBAN6f5K5A==" src="https://github.githubassets.com/assets/element-registry-1ea8e3972a44.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-kLhIYVjAXJ2hXeyCEm3URfd7vkVJppjyVHGZgh7ihO1SxQOEsjxaeb+fHdHG55Z6M/RcS/DhAkiBLsTcOQ7gLg==" src="https://github.githubassets.com/assets/vendors-node_modules_lit-html_lit-html_js-90b8486158c0.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-3SyoVPgIZ3COEg8FBG3Me5pypRq/PHsQlsoYTPrm9h7MZhS4bTOiKxL61LqwFDm375GRaFW2g3GUXQN5F4pxgA==" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_github_hotkey_dist_index-9f48bd-dd2ca854f808.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-ttmm0QLZY8fxY74dwIpI2/d/17eYOzsD2Gl6aUZZ7u+k5t7PrcyXbnfH2US9smnB6ygJUY26BP6OLP4GAP0FDg==" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_scroll-anchoring_dist_scro-5881a7-b6d9a6d102d9.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-QRpxs/h4rosCrPVNsJqngkNuY4kG63lXQhzzp+Qswtm8UzwFToJxDtxINMICWPHLxVJCAXi+gaGBy0rt84gKNQ==" src="https://github.githubassets.com/assets/vendors-node_modules_github_paste-markdown_dist_index_esm_js-node_modules_github_quote-select-b114cf-411a71b3f878.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-BysfurlZLa+kGOWYPyCk2MRkf0EAYydE6gAreHRtFt7OLvH4CA+GiVPItEIcswESp++Hdlx4zq6lyEg44Xlmzg==" src="https://github.githubassets.com/assets/app_assets_modules_github_soft-nav_navigate_ts-072b1fbab959.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-+NIA1YfKweEgg48fHVRhI4MDRwQFcXnCgXLPP7oxQzpzQsgsQ2dpCXIMnlsipk4oVNf/WhEGNX1IjWOEXkxKKw==" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_keyboard-shortcuts-helper_ts-app_assets_modules_github_di-9b8a64-f8d200d587ca.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-Y6P6iEyMBROE+M9c4vHdqemcFJ1CVrqMRVbiq3OGaEJ6WAY5hcc1QG47hcKTTejSLMMbRvB90wKrOKntY393Zg==" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_task-list_ts-app_assets_modules_github_has-interactions_t-0091d6-63a3fa884c8c.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-elEAjlOaE3+ADn59gSrSDm/DLJnQWpT5e2nOWJttk7KT7BdGB63Kv8WXHTQjjVHUYinyc0EsbhmTxcDOPplDYg==" src="https://github.githubassets.com/assets/app_assets_modules_github_behaviors_details_ts-app_assets_modules_github_behaviors_include-fr-a78de3-7a51008e539a.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-zBV3Z9LW/2mTMTRKvz/L900np00McXWlmIKwSdpDdVsIREB0SuyjsidkRxxB3F4CB1XZKSYCmBMFse1XRAaJLA==" src="https://github.githubassets.com/assets/behaviors-cc157767d2d6.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-3WKbPWWjtzdX85Bzbcgwipn1M+jRnHd3W8y8uKGo7fxXEXnh0IIKxQ5BnOhy1uHSp2JQuro134aD3M4VEr2feA==" src="https://github.githubassets.com/assets/notifications-global-dd629b3d65a3.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-3fCYU1hYWHyJnEFKFnZbXL+K3pIXJiqq5pI7zzANIabOwxZTPqLTISzWf8DV0U1L2WhKEZKunjlx9EqsorfjjQ==" src="https://github.githubassets.com/assets/vendors-node_modules_virtualized-list_es_index_js-node_modules_github_template-parts_lib_index_js-ddf098535858.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-Ajgez6F/m0LA3+5INxS8A4LhMVX56KcUQLQ/FKMOMQLyfoT9kV5y8vpmtdYAUJH86dT7bna0uLmdUXpAHKl6mg==" src="https://github.githubassets.com/assets/vendors-node_modules_github_remote-form_dist_index_js-node_modules_delegated-events_dist_inde-16f3e12-02381ecfa17f.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-1NiFwIV6p73Fr55SqiNFH8R2R+XKiN/8fIObLIUQS22L+oO17quwvK+qrsyMMO8sckW77VVdvH8VPVH0HNg3Kg==" src="https://github.githubassets.com/assets/codespaces-d4d885c0857a.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-kgpS+MXAle9xlo1l7/jg6RhVRu208n8DQsKCL4ASBCLx6YUtldMZtzTHDPWToL6j6LQ0OW0sa+9Q9OBuJTQ/HA==" src="https://github.githubassets.com/assets/vendors-node_modules_github_clipboard-copy-element_dist_index_esm_js-node_modules_github_remo-8e6bec-920a52f8c5c0.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-6SdYPU9K8a3CF6UeWXw3/qtcGLPy1q06OVmct5grwudBVuZAczpsQZtedwdBGz5nVCJ7Y+F1So2fubBGIzDMDQ==" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_scroll-anchoring_di-a017b0-e927583d4f4a.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-LO7L/S9Cv4EuzHNZlaQ4s2xtIfbmAc/MhBM4czs2gUcotc6CvJfJz1kv0KrQWuED3kbRsaJAtdZ1wgYLJbM1EQ==" src="https://github.githubassets.com/assets/app_assets_modules_github_diffs_blob-lines_ts-app_assets_modules_github_diffs_linkable-line-n-f314c3-2ceecbfd2f42.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-098YYSKfJi4sAkf2bikIRAYnnAhPTZALKJntajLxOpiEHV2GSWmfSDZh5XV6TjKQD0dD1ys7qRGN9e76yZCuBg==" src="https://github.githubassets.com/assets/app_assets_modules_github_fetch_ts-app_assets_modules_github_input-demux_ts-app_assets_module-e5b55c-d3df1861229f.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-HMWMzZYw4dvsOtMXCTjRoUMzURzgxU2wfGHT/kSy6brwVsPQ40VAfobwSEzdSkDvyncqZZnVLbdRvGpfjnVduA==" src="https://github.githubassets.com/assets/diffs-1cc58ccd9630.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-/0ZgTj/w7DQ3el5ZtSlU4ULbPjigitJdNuJF2o14lvXWs/WduHdRQlV0E8NnSOorJnb/m3QvEwSDFRsynxBrNg==" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_delegated-events_dist_in-3fcf56-ff46604e3ff0.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-X3L3iyjqp4MCArnaA4NNIeIzPHIOzvKFZDWDTlXmo4uU+9ACP69y/r3UaYeFOVLPjEzwqCUk2ANROA0tiWQnHQ==" src="https://github.githubassets.com/assets/scanning-5f72f78b28ea.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-L7ZLOuw1l1EsBol+e877vCS6AzLZE+iiBS+CB3R3kz3GLWZxk7J4w+tc/x8oCaJdp0ow0CXxXiPtwk5RUn5AiA==" src="https://github.githubassets.com/assets/code-menu-2fb64b3aec35.js"></script>
<title>doc: Update importaddress mention incompatibility with descriptor wallet by brokenprogrammer · Pull Request #25368 · bitcoin/bitcoin</title>
<meta name="request-id" content="D49B:47CD:10A6A5D:23C1199:62DDC08D" data-pjax-transient="true" /><meta name="html-safe-nonce" content="2da5ac6d94c66ccbc60c806e56619a3dd0f64013a554f75e9aedd49bfc7dcdad" data-pjax-transient="true" /><meta name="visitor-payload" content="eyJyZWZlcnJlciI6bnVsbCwicmVxdWVzdF9pZCI6IkQ0OUI6NDdDRDoxMEE2QTVEOjIzQzExOTk6NjJEREMwOEQiLCJ2aXNpdG9yX2lkIjoiODQ3OTE5NjQ0MjU0ODYxMjA4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9" data-pjax-transient="true" /><meta name="visitor-hmac" content="c31685ca87a3c3d4feba680b3b8f88b66ab96e72bab9b86e564c882474b849e7" data-pjax-transient="true" />
<meta name="hovercard-subject-tag" content="pull_request:966754432" data-pjax-transient>
<meta name="github-keyboard-shortcuts" content="repository,pull-request-list,pull-request-conversation,pull-request-files-changed" data-pjax-transient="true" />
<meta name="selected-link" value="repo_pulls" data-pjax-transient>
<meta name="google-site-verification" content="c1kuD-K2HIVF635lypcsWPoD4kilo5-jA_wBFyT4uMY">
<meta name="google-site-verification" content="KT5gs8h0wvaagLKAVWq8bbeNwnZZK1r1XQysX3xurLU">
<meta name="google-site-verification" content="ZzhVyEFwb7w3e0-uOTltm8Jsck2F5StVihD0exw2fsA">
<meta name="google-site-verification" content="GXs5KoUUkNCoaAZn7wPN-t01Pywp9M3sEjnt_3_ZWPc">
<meta name="octolytics-url" content="https://collector.github.com/github/collect" /><meta name="octolytics-actor-id" content="109906674" /><meta name="octolytics-actor-login" content="JOHNJOHN2133" /><meta name="octolytics-actor-hash" content="7c26c4406c1f489bac4168544ed0ad5870f8ade21823faa06864b715fb120273" />
<meta name="analytics-location" content="/<user-name>/<repo-name>/pull_requests/show/commits" data-pjax-transient="true" />
<meta name="user-login" content="JOHNJOHN2133">
<meta name="viewport" content="width=device-width">
<meta name="description" content="This is related to #25363 and offers a small update to the error messages from EnsureLegacyScriptPubKeyMan and EnsureConstLegacyScriptPubKeyMan to mention that they only are compatible with legacy wallets.
The RPC documentation for importaddress is also updated to mention this as well as guide the user to the alternative importdescriptors for cases when using descriptor wallets.
I'm thinking that we can introduce a "porting guide" document mentioned in #25363 in a separate PR since I would have to make myself more familiar with the subject before being able to tackle that.">
<link rel="search" type="application/opensearchdescription+xml" href="/opensearch.xml" title="GitHub">
<link rel="fluid-icon" href="https://github.com/fluidicon.png" title="GitHub">
<meta property="fb:app_id" content="1401488693436528">
<meta name="apple-itunes-app" content="app-id=1477376905" />
<meta name="twitter:image:src" content="https://avatars.githubusercontent.com/u/16289144?s=400&v=4" /><meta name="twitter:site" content="@github" /><meta name="twitter:card" content="summary_large_image" /><meta name="twitter:title" content="doc: Update importaddress mention incompatibility with descriptor wallet by brokenprogrammer · Pull Request #25368 · bitcoin/bitcoin" /><meta name="twitter:description" content="This is related to #25363 and offers a small update to the error messages from EnsureLegacyScriptPubKeyMan and EnsureConstLegacyScriptPubKeyMan to mention that they only are compatible with legacy ..." />
<meta property="og:image" content="https://avatars.githubusercontent.com/u/16289144?s=400&v=4" /><meta property="og:image:alt" content="This is related to #25363 and offers a small update to the error messages from EnsureLegacyScriptPubKeyMan and EnsureConstLegacyScriptPubKeyMan to mention that they only are compatible with legacy ..." /><meta property="og:site_name" content="GitHub" /><meta property="og:type" content="object" /><meta property="og:title" content="doc: Update importaddress mention incompatibility with descriptor wallet by brokenprogrammer · Pull Request #25368 · bitcoin/bitcoin" /><meta property="og:url" content="https://github.com/bitcoin/bitcoin/pull/25368" /><meta property="og:description" content="This is related to #25363 and offers a small update to the error messages from EnsureLegacyScriptPubKeyMan and EnsureConstLegacyScriptPubKeyMan to mention that they only are compatible with legacy ..." />
<link rel="assets" href="https://github.githubassets.com/">
<link rel="shared-web-socket" href="wss://alive.github.com/_sockets/u/109906674/ws?session=eyJ2IjoiVjMiLCJ1IjoxMDk5MDY2NzQsInMiOjkyMTUwMjI1MCwiYyI6MTEwMjA4NTg5MiwidCI6MTY1ODY5OTkxOH0=--c1dccc417e38a71d3887fdeaa0766ef95048a9462bea5c4ce364ed63d17de603" data-refresh-url="/_alive" data-session-id="937e72e5d49c129d1ab8c2decad4f223a3d762c7676c8e6495dc19ef926246b3">
<link rel="shared-web-socket-src" href="/assets-cdn/worker/socket-worker-04675b6c9780.js">
<link rel="sudo-modal" href="/sessions/sudo_modal">
<meta name="hostname" content="github.com">
<meta name="keyboard-shortcuts-preference" content="all">
<script type="application/json" id="memex_keyboard_shortcuts_preference">"all"</script>
<meta name="expected-hostname" content="github.com">
<meta name="enabled-features" content="PRESENCE_IDLE,IMAGE_METRIC_TRACKING,GEOJSON_AZURE_MAPS">
<meta http-equiv="x-pjax-version" content="22d995fa726619727f6b2d032b2febc713b80d43b5d3667f2721b7f63f670ac0" data-turbo-track="reload">
<meta http-equiv="x-pjax-csp-version" content="485d6a5ccbb1eeae9c86b616b4870b531f6f458e8bd5c309c40280dc4f51defb" data-turbo-track="reload">
<meta http-equiv="x-pjax-css-version" content="f0e7d7bccc8c1b3aebce2b52c98c94ee031c8144bcb64ade76ad7dcb39d029bb" data-turbo-track="reload">
<meta http-equiv="x-pjax-js-version" content="c6d91a0a1ee002dd8825f9109b23e7d083c7a0d0eae40ad3785b65d8d77aa9d3" data-turbo-track="reload">
<meta name="turbo-cache-control" content="no-preview" data-pjax-transient="">
<link data-pjax-transient rel="alternate" type="text/x-diff" href="/bitcoin/bitcoin/pull/25368.diff">
<link data-pjax-transient rel="alternate" type="text/x-patch" href="/bitcoin/bitcoin/pull/25368.patch">
<meta name="diff-view" content="unified" data-pjax-transient>
<meta name="go-import" content="github.com/bitcoin/bitcoin git https://github.com/bitcoin/bitcoin.git">
<meta name="octolytics-dimension-user_id" content="528860" /><meta name="octolytics-dimension-user_login" content="bitcoin" /><meta name="octolytics-dimension-repository_id" content="1181927" /><meta name="octolytics-dimension-repository_nwo" content="bitcoin/bitcoin" /><meta name="octolytics-dimension-repository_public" content="true" /><meta name="octolytics-dimension-repository_is_fork" content="false" /><meta name="octolytics-dimension-repository_network_root_id" content="1181927" /><meta name="octolytics-dimension-repository_network_root_nwo" content="bitcoin/bitcoin" />
<meta name="turbo-body-classes" content="logged-in env-production page-responsive full-width">
<meta name="browser-stats-url" content="https://api.github.com/_private/browser/stats">
<meta name="browser-errors-url" content="https://api.github.com/_private/browser/errors">
<meta name="browser-optimizely-client-errors-url" content="https://api.github.com/_private/browser/optimizely_client/errors">
<link rel="mask-icon" href="https://github.githubassets.com/pinned-octocat.svg" color="#000000">
<link rel="alternate icon" class="js-site-favicon" type="image/png" href="https://github.githubassets.com/favicons/favicon.png">
<link rel="icon" class="js-site-favicon" type="image/svg+xml" href="https://github.githubassets.com/favicons/favicon.svg">
<meta name="theme-color" content="#1e2327">
<meta name="color-scheme" content="light dark" />
<link rel="apple-touch-icon" href="https://github.githubassets.com/apple-touch-icon.png">
<link rel="apple-touch-icon" sizes="180x180" href="https://github.githubassets.com/apple-touch-icon-180x180.png">
<meta name="apple-mobile-web-app-title" content="GitHub">
<link rel="manifest" href="/manifest.json" crossOrigin="use-credentials">
</head>
<body class="logged-in env-production page-responsive full-width" style="word-wrap: break-word;">
<div class="position-relative js-header-wrapper ">
<a href="#start-of-content" class="p-3 color-bg-accent-emphasis color-fg-on-emphasis show-on-focus js-skip-to-content">Skip to content</a>
<span data-view-component="true" class="progress-pjax-loader js-pjax-loader-bar Progress position-fixed width-full">
<span style="width: 0%;" data-view-component="true" class="Progress-item progress-pjax-loader-bar left-0 top-0 color-bg-accent-emphasis"></span>
</span>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-qmzLUPhRwjLnWYbgkPs8gTtIXLhH2/2ylMinT7zJNQa3RJGDUT2ErP7cbmhRCbbKlDyUDZ/93D1K+VCZcGHQUg==" src="https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_decorators_js-node_modules_github_command-pale-4090c9-aa6ccb50f851.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-ab0A5Q5/uus0+x9qew5LfTCFG1FdKbpuG0zDvs8IkeG8ZUGy1gJl8jyhspptxXEn4fYRDuLXsyUv7phf7yjSpg==" src="https://github.githubassets.com/assets/vendors-node_modules_github_clipboard-copy-element_dist_index_esm_js-node_modules_delegated-e-e4591b-69bd00e50e7f.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-05vw09hX4jkyFSz5J2cFUkeBDcbdqEM1LCQUEA0KVUZOjHLLvGdlwVjpXFxq9UlExXyOnvyrtV7fz/AglblZeA==" src="https://github.githubassets.com/assets/app_assets_modules_github_command-palette_items_help-item_ts-app_assets_modules_github_comman-7e29fd-d39bf0d3d857.js"></script>
<script crossorigin="anonymous" defer="defer" type="application/javascript" integrity="sha512-pGKxH0kolaYS1jSWfxiPOJF9ipo9Ym+6yzQrUSbA+SVrPAofREKGzrrf+I/rFvvQ9jaBSJS5enBrgy0OYhK2uw==" src="https://github.githubassets.com/assets/command-palette-a462b11f4928.js"></script>
<header class="Header js-details-container Details px-3 px-md-4 px-lg-5 flex-wrap flex-md-nowrap" role="banner" >
<div class="Header-item mt-n1 mb-n1 d-none d-md-flex">
<a
class="Header-link "
href="https://github.com/"
data-hotkey="g d"
aria-label="Homepage "
data-turbo="false"
data-analytics-event="{"category":"Header","action":"go to dashboard","label":"icon:logo"}"
>
<svg height="32" aria-hidden="true" viewBox="0 0 16 16" version="1.1" width="32" data-view-component="true" class="octicon octicon-mark-github v-align-middle">
<path fill-rule="evenodd" d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01 1.08.58 1.23.82.72 1.21 1.87.87 2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0016 8c0-4.42-3.58-8-8-8z"></path>
</svg>
</a>
</div>
<div class="Header-item d-md-none">
<button aria-label="Toggle navigation" aria-expanded="false" type="button" data-view-component="true" class="Header-link js-details-target btn-link"> <svg aria-hidden="true" height="24" viewBox="0 0 16 16" version="1.1" width="24" data-view-component="true" class="octicon octicon-three-bars">
<path fill-rule="evenodd" d="M1 2.75A.75.75 0 011.75 2h12.5a.75.75 0 110 1.5H1.75A.75.75 0 011 2.75zm0 5A.75.75 0 011.75 7h12.5a.75.75 0 110 1.5H1.75A.75.75 0 011 7.75zM1.75 12a.75.75 0 100 1.5h12.5a.75.75 0 100-1.5H1.75z"></path>
</svg>
</button> </div>
<div class="Header-item Header-item--full flex-column flex-md-row width-full flex-order-2 flex-md-order-none mr-0 mt-3 mt-md-0 Details-content--hidden-not-important d-md-flex">
<div class="header-search flex-auto js-site-search position-relative flex-self-stretch flex-md-self-auto mb-3 mb-md-0 mr-0 mr-md-3 scoped-search site-scoped-search"
>
<div class="position-relative">
<!-- '"` --><!-- </textarea></xmp> --></option></form><form class="js-site-search-form" role="search" aria-label="Site" data-scope-type="Repository" data-scope-id="1181927" data-scoped-search-url="/bitcoin/bitcoin/search" data-owner-scoped-search-url="/orgs/bitcoin/search" data-unscoped-search-url="/search" data-turbo="false" action="/bitcoin/bitcoin/search" accept-charset="UTF-8" method="get">
<label class="form-control input-sm header-search-wrapper p-0 js-chromeless-input-container">
<a class="header-search-scope no-underline" href="/bitcoin/bitcoin/pull/25368/commits/e3609cdc01cf992800f28b20b0107b7fdc1f880e">This repository</a>
<input type="text"
class="form-control input-sm header-search-input js-site-search-focus js-site-search-field is-clearable"
data-hotkey=s,/
name="q"
data-test-selector="nav-search-input"
placeholder="Search"
data-unscoped-placeholder="Search GitHub"
data-scoped-placeholder="Search"
autocapitalize="off"
aria-label="Search this repository"
>
<input type="hidden" value="hVJ-WQovhf2QmglogJ1wUxflareaJ5HUqQOjWkufwcWVloy4YPR6Dd7dTOq4iArFcAblTEMgFQOdzacdskP08g" data-csrf="true" class="js-data-jump-to-suggestions-path-csrf" />
<input type="hidden" class="js-site-search-type-field" name="type" >
</label>
</form> </div>
</div>
<nav id="global-nav" class="d-flex flex-column flex-md-row flex-self-stretch flex-md-self-auto" aria-label="Global">
<a class="Header-link py-md-3 d-block d-md-none py-2 border-top border-md-top-0 border-white-fade" data-ga-click="Header, click, Nav menu - item:dashboard:user" aria-label="Dashboard" data-turbo="false" href="/dashboard">Dashboard</a>
<a class="js-selected-navigation-item Header-link mt-md-n3 mb-md-n3 py-2 py-md-3 mr-0 mr-md-3 border-top border-md-top-0 border-white-fade" data-hotkey="g p" data-ga-click="Header, click, Nav menu - item:pulls context:user" aria-label="Pull requests you created" data-turbo="false" data-selected-links="/pulls /pulls/assigned /pulls/mentioned /pulls" href="/pulls">
Pull<span class="d-inline d-md-none d-lg-inline"> request</span>s
</a>
<a class="js-selected-navigation-item Header-link mt-md-n3 mb-md-n3 py-2 py-md-3 mr-0 mr-md-3 border-top border-md-top-0 border-white-fade" data-hotkey="g i" data-ga-click="Header, click, Nav menu - item:issues context:user" aria-label="Issues you created" data-turbo="false" data-selected-links="/issues /issues/assigned /issues/mentioned /issues" href="/issues">Issues</a>
<div class="d-flex position-relative">
<a class="js-selected-navigation-item Header-link flex-auto mt-md-n3 mb-md-n3 py-2 py-md-3 mr-0 mr-md-3 border-top border-md-top-0 border-white-fade" data-ga-click="Header, click, Nav menu - item:marketplace context:user" data-octo-click="marketplace_click" data-octo-dimensions="location:nav_bar" data-turbo="false" data-selected-links=" /marketplace" href="/marketplace">Marketplace</a>
</div>
<a class="js-selected-navigation-item Header-link mt-md-n3 mb-md-n3 py-2 py-md-3 mr-0 mr-md-3 border-top border-md-top-0 border-white-fade" data-ga-click="Header, click, Nav menu - item:explore" data-turbo="false" data-selected-links="/explore /trending /trending/developers /integrations /integrations/feature/code /integrations/feature/collaborate /integrations/feature/ship showcases showcases_search showcases_landing /explore" href="/explore">Explore</a>
<a class="js-selected-navigation-item Header-link d-block d-md-none py-2 py-md-3 border-top border-md-top-0 border-white-fade" data-ga-click="Header, click, Nav menu - item:workspaces context:user" data-turbo="false" data-selected-links="/codespaces /codespaces" href="/codespaces">Codespaces</a>
<a class="js-selected-navigation-item Header-link d-block d-md-none py-2 py-md-3 border-top border-md-top-0 border-white-fade" data-ga-click="Header, click, Nav menu - item:Sponsors" data-hydro-click="{"event_type":"sponsors.button_click","payload":{"button":"HEADER_SPONSORS_DASHBOARD","sponsorable_login":"JOHNJOHN2133","originating_url":"https://github.com/bitcoin/bitcoin/pull/25368/commits/e3609cdc01cf992800f28b20b0107b7fdc1f880e","user_id":109906674}}" data-hydro-click-hmac="dfc00f8efef6ac2fa3e08c416d9813555403dd30836bde0e28e0332b54565966" data-turbo="false" data-selected-links=" /sponsors/accounts" href="/sponsors/accounts">Sponsors</a>
<a class="Header-link d-block d-md-none mr-0 mr-md-3 py-2 py-md-3 border-top border-md-top-0 border-white-fade" data-turbo="false" href="/settings/profile">Settings</a>
<a class="Header-link d-block d-md-none mr-0 mr-md-3 py-2 py-md-3 border-top border-md-top-0 border-white-fade" data-turbo="false" href="/JOHNJOHN2133">
<img class="avatar avatar-user" loading="lazy" decoding="async" src="https://avatars.githubusercontent.com/u/109906674?s=40&v=4" width="20" height="20" alt="@JOHNJOHN2133" />
JOHNJOHN2133
</a>
<!-- '"` --><!-- </textarea></xmp> --></option></form><form data-turbo="false" action="/logout" accept-charset="UTF-8" method="post"><input type="hidden" name="authenticity_token" value="nQGqEknB2bq33o4yLv8DZMS4FcWotn4Cx8svAj68R_9s3CcP5TJyB3my6XYR_KOAS1MvbGVeldtW4y2N1t-jIg" />
<button
type="submit"
class="Header-link mr-0 mr-md-3 py-2 py-md-3 border-top border-md-top-0 border-white-fade d-md-none btn-link d-block width-full text-left"
style="padding-left: 2px;"
data-analytics-event="{"category":"Header","action":"sign out","label":"icon:logout"}"
>
<svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-sign-out v-align-middle">
<path fill-rule="evenodd" d="M2 2.75C2 1.784 2.784 1 3.75 1h2.5a.75.75 0 010 1.5h-2.5a.25.25 0 00-.25.25v10.5c0 .138.112.25.25.25h2.5a.75.75 0 010 1.5h-2.5A1.75 1.75 0 012 13.25V2.75zm10.44 4.5H6.75a.75.75 0 000 1.5h5.69l-1.97 1.97a.75.75 0 101.06 1.06l3.25-3.25a.75.75 0 000-1.06l-3.25-3.25a.75.75 0 10-1.06 1.06l1.97 1.97z"></path>
</svg>
Sign out
</button>
</form></nav>
</div>
<div class="Header-item Header-item--full flex-justify-center d-md-none position-relative">
<a
class="Header-link "
href="https://github.com/"
data-hotkey="g d"
aria-label="Homepage "
data-turbo="false"
data-analytics-event="{"category":"Header","action":"go to dashboard","label":"icon:logo"}"
>
<svg height="32" aria-hidden="true" viewBox="0 0 16 16" version="1.1" width="32" data-view-component="true" class="octicon octicon-mark-github v-align-middle">
<path fill-rule="evenodd" d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01 1.08.58 1.23.82.72 1.21 1.87.87 2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 1.32-.27 2-.27.68 0 1.36.09 2 .27 1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0016 8c0-4.42-3.58-8-8-8z"></path>
</svg>
</a>
</div>
<div class="Header-item mr-0 mr-md-3 flex-order-1 flex-md-order-none">
<notification-indicator
class=" js-socket-channel"
data-channel="eyJjIjoibm90aWZpY2F0aW9uLWNoYW5nZWQ6MTA5OTA2Njc0IiwidCI6MTY1ODY5OTkxOH0=--57734ba54bfad3a64f2284b8b15127eebd68a614f1d83e5080d3bab983f64b39"
data-indicator-mode="none"
data-tooltip-global="You have unread notifications"
data-tooltip-unavailable="Notifications are unavailable at the moment."
data-tooltip-none="You have no unread notifications"
>
<a href="/notifications"
class="Header-link notification-indicator position-relative tooltipped tooltipped-sw"
data-hotkey="g n"
data-target="notification-indicator.link"
data-analytics-event="{"category":"Header","action":"go to notifications","label":"icon:read"}">
<span
data-target="notification-indicator.badge"
class="mail-status unread" hidden>
</span>
<svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-bell">
<path d="M8 16a2 2 0 001.985-1.75c.017-.137-.097-.25-.235-.25h-3.5c-.138 0-.252.113-.235.25A2 2 0 008 16z"></path><path fill-rule="evenodd" d="M8 1.5A3.5 3.5 0 004.5 5v2.947c0 .346-.102.683-.294.97l-1.703 2.556a.018.018 0 00-.003.01l.001.006c0 .002.002.004.004.006a.017.017 0 00.006.004l.007.001h10.964l.007-.001a.016.016 0 00.006-.004.016.016 0 00.004-.006l.001-.007a.017.017 0 00-.003-.01l-1.703-2.554a1.75 1.75 0 01-.294-.97V5A3.5 3.5 0 008 1.5zM3 5a5 5 0 0110 0v2.947c0 .05.015.098.042.139l1.703 2.555A1.518 1.518 0 0113.482 13H2.518a1.518 1.518 0 01-1.263-2.36l1.703-2.554A.25.25 0 003 7.947V5z"></path>
</svg>
</a>
</notification-indicator>
</div>
<div class="Header-item position-relative d-none d-md-flex">
<details class="details-overlay details-reset">
<summary
class="Header-link"
aria-label="Create new…"
data-analytics-event="{"category":"Header","action":"create new","label":"icon:add"}"
>
<svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-plus">
<path fill-rule="evenodd" d="M7.75 2a.75.75 0 01.75.75V7h4.25a.75.75 0 110 1.5H8.5v4.25a.75.75 0 11-1.5 0V8.5H2.75a.75.75 0 010-1.5H7V2.75A.75.75 0 017.75 2z"></path>
</svg> <span class="dropdown-caret"></span>
</summary>
<details-menu class="dropdown-menu dropdown-menu-sw">
<a role="menuitem" class="dropdown-item" href="/new" data-ga-click="Header, create new repository">
New repository
</a>
<a role="menuitem" class="dropdown-item" href="/new/import" data-ga-click="Header, import a repository">
Import repository
</a>
<a role="menuitem" class="dropdown-item" href="https://gist.github.com/" data-ga-click="Header, create new gist">
New gist
</a>
<a role="menuitem" class="dropdown-item" href="/organizations/new" data-ga-click="Header, create new organization">
New organization
</a>
</details-menu>
</details>
</div>
<div class="Header-item position-relative mr-0 d-none d-md-flex">
<details class="details-overlay details-reset js-feature-preview-indicator-container" data-feature-preview-indicator-src="/users/JOHNJOHN2133/feature_preview/indicator_check">
<summary
class="Header-link"
aria-label="View profile and more"
data-analytics-event="{"category":"Header","action":"show menu","label":"icon:avatar"}"
>
<img src="https://avatars.githubusercontent.com/u/109906674?s=40&v=4" alt="@JOHNJOHN2133" size="20" height="20" width="20" data-view-component="true" class="avatar avatar-small circle" />
<span class="unread-indicator js-feature-preview-indicator" style="top: 1px;" hidden></span>
<span class="dropdown-caret"></span>
</summary>
<details-menu
class="dropdown-menu dropdown-menu-sw"
style="width: 180px"
preload>
<include-fragment src="/users/109906674/menu" loading="lazy">
<p class="text-center mt-3" data-hide-on-error>
<svg style="box-sizing: content-box; color: var(--color-icon-primary);" width="32" height="32" viewBox="0 0 16 16" fill="none" data-view-component="true" class="anim-rotate">
<circle cx="8" cy="8" r="7" stroke="currentColor" stroke-opacity="0.25" stroke-width="2" vector-effect="non-scaling-stroke" />
<path d="M15 8a7.002 7.002 0 00-7-7" stroke="currentColor" stroke-width="2" stroke-linecap="round" vector-effect="non-scaling-stroke" />
</svg>
</p>
<p class="ml-1 mb-2 mt-2 color-fg-default" data-show-on-error>
<svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert">
<path fill-rule="evenodd" d="M8.22 1.754a.25.25 0 00-.44 0L1.698 13.132a.25.25 0 00.22.368h12.164a.25.25 0 00.22-.368L8.22 1.754zm-1.763-.707c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0114.082 15H1.918a1.75 1.75 0 01-1.543-2.575L6.457 1.047zM9 11a1 1 0 11-2 0 1 1 0 012 0zm-.25-5.25a.75.75 0 00-1.5 0v2.5a.75.75 0 001.5 0v-2.5z"></path>
</svg>
Sorry, something went wrong.
</p>
</include-fragment>
</details-menu>
</details>
</div>
</header>
</div>
<div id="start-of-content" class="show-on-focus"></div>
<div data-pjax-replace id="js-flash-container" data-turbo-replace>
<template class="js-flash-template">
<div class="flash flash-full {{ className }}">
<div class="px-2" >
<button class="flash-close js-flash-close" type="button" aria-label="Dismiss this message">
<svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x">
<path fill-rule="evenodd" d="M3.72 3.72a.75.75 0 011.06 0L8 6.94l3.22-3.22a.75.75 0 111.06 1.06L9.06 8l3.22 3.22a.75.75 0 11-1.06 1.06L8 9.06l-3.22 3.22a.75.75 0 01-1.06-1.06L6.94 8 3.72 4.78a.75.75 0 010-1.06z"></path>
</svg>
</button>
<div>{{ message }}</div>
</div>
</div>
</template>
</div>
<include-fragment class="js-notification-shelf-include-fragment" data-base-src="https://github.com/notifications/beta/shelf"></include-fragment>
<details
class="details-reset details-overlay details-overlay-dark js-command-palette-dialog"
data-pjax-replace
id="command-palette-pjax-container"
data-turbo-replace
>
<summary aria-label="command palette trigger">
</summary>
<details-dialog class="command-palette-details-dialog d-flex flex-column flex-justify-center height-fit" aria-label="command palette">
<command-palette
class="command-palette color-bg-default rounded-3 border color-shadow-small"
data-return-to=/bitcoin/bitcoin/pull/25368/commits/e3609cdc01cf992800f28b20b0107b7fdc1f880e
data-user-id="109906674"
data-activation-hotkey="Mod+k,Mod+Alt+k"
data-command-mode-hotkey="Mod+Shift+k"
data-action="
command-palette-page-stack-updated:command-palette#updateInputScope
itemsUpdated:command-palette#itemsUpdated
keydown:command-palette#onKeydown
loadingStateChanged:command-palette#loadingStateChanged
selectedItemChanged:command-palette#selectedItemChanged
pageFetchError:command-palette#pageFetchError
">
<command-palette-mode
data-char="#"
data-scope-types="[""]"
data-placeholder="Search issues and pull requests"
></command-palette-mode>
<command-palette-mode
data-char="#"
data-scope-types="["owner","repository"]"
data-placeholder="Search issues, pull requests, discussions, and projects"
></command-palette-mode>
<command-palette-mode
data-char="!"
data-scope-types="["owner","repository"]"
data-placeholder="Search projects"
></command-palette-mode>
<command-palette-mode
data-char="@"
data-scope-types="[""]"
data-placeholder="Search or jump to a user, organization, or repository"
></command-palette-mode>
<command-palette-mode
data-char="@"
data-scope-types="["owner"]"
data-placeholder="Search or jump to a repository"
></command-palette-mode>
<command-palette-mode
data-char="/"
data-scope-types="["repository"]"
data-placeholder="Search files"
></command-palette-mode>
<command-palette-mode
data-char="?"
></command-palette-mode>
<command-palette-mode
data-char=">"
data-placeholder="Run a command"
></command-palette-mode>
<command-palette-mode
data-char=""
data-scope-types="[""]"
data-placeholder="Search or jump to..."
></command-palette-mode>
<command-palette-mode
data-char=""
data-scope-types="["owner"]"
data-placeholder="Search or jump to..."
></command-palette-mode>
<command-palette-mode
class="js-command-palette-default-mode"
data-char=""
data-placeholder="Search or jump to..."
></command-palette-mode>
<command-palette-input placeholder="Search or jump to..."
data-action="
command-palette-input:command-palette#onInput
command-palette-select:command-palette#onSelect
command-palette-descope:command-palette#onDescope
command-palette-cleared:command-palette#onInputClear
"
>
<div class="js-search-icon d-flex flex-items-center mr-2" style="height: 26px">
<svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-search color-fg-muted">
<path fill-rule="evenodd" d="M11.5 7a4.499 4.499 0 11-8.998 0A4.499 4.499 0 0111.5 7zm-.82 4.74a6 6 0 111.06-1.06l3.04 3.04a.75.75 0 11-1.06 1.06l-3.04-3.04z"></path>
</svg>
</div>
<div class="js-spinner d-flex flex-items-center mr-2 color-fg-muted" hidden>
<svg aria-label="Loading" class="anim-rotate" viewBox="0 0 16 16" fill="none" width="16" height="16">
<circle
cx="8"
cy="8"
r="7"
stroke="currentColor"
stroke-opacity="0.25"
stroke-width="2"
vector-effect="non-scaling-stroke"
></circle>
<path
d="M15 8a7.002 7.002 0 00-7-7"
stroke="currentColor"
stroke-width="2"
stroke-linecap="round"
vector-effect="non-scaling-stroke"
></path>
</svg>
</div>
<command-palette-scope >
<div data-target="command-palette-scope.placeholder" hidden class="color-fg-subtle">/ <span class="text-semibold color-fg-default">...</span> / </div>
<command-palette-token
data-text="bitcoin"
data-id="MDEyOk9yZ2FuaXphdGlvbjUyODg2MA=="
data-type="owner"
data-value="bitcoin"
data-targets="command-palette-scope.tokens"
class="color-fg-default text-semibold"
style="white-space:nowrap;line-height:20px;"
>bitcoin<span class="color-fg-subtle text-normal"> / </span></command-palette-token>
<command-palette-token
data-text="bitcoin"
data-id="MDEwOlJlcG9zaXRvcnkxMTgxOTI3"
data-type="repository"
data-value="bitcoin"
data-targets="command-palette-scope.tokens"
class="color-fg-default text-semibold"
style="white-space:nowrap;line-height:20px;"
>bitcoin<span class="color-fg-subtle text-normal"> / </span></command-palette-token>
<command-palette-token
data-text="Pull requests #25368"
data-id="PR_kwDOABII5845n4CA"
data-type="pull_request"
data-value="Pull requests #25368"
data-targets="command-palette-scope.tokens"
class="color-fg-default text-semibold"
style="white-space:nowrap;line-height:20px;"
>Pull requests #25368<span class="color-fg-subtle text-normal"> / </span></command-palette-token>
</command-palette-scope>
<div class="command-palette-input-group flex-1 form-control border-0 box-shadow-none" style="z-index: 0">
<div class="command-palette-typeahead position-absolute d-flex flex-items-center Truncate">
<span class="typeahead-segment input-mirror" data-target="command-palette-input.mirror"></span>
<span class="Truncate-text" data-target="command-palette-input.typeaheadText"></span>
<span class="typeahead-segment" data-target="command-palette-input.typeaheadPlaceholder"></span>
</div>
<input
class="js-overlay-input typeahead-input d-none"
disabled
tabindex="-1"
aria-label="Hidden input for typeahead"
>
<input
type="text"
autocomplete="off"
autocorrect="off"
autocapitalize="off"
spellcheck="false"
class="js-input typeahead-input form-control border-0 box-shadow-none input-block width-full no-focus-indicator"
aria-label="Command palette input"
aria-haspopup="listbox"
aria-expanded="false"
aria-autocomplete="list"
aria-controls="command-palette-page-stack"
role="combobox"
data-action="
input:command-palette-input#onInput
keydown:command-palette-input#onKeydown
"
>
</div>
<button aria-label="clear command palette" aria-keyshortcuts="Control+Backspace" data-action="click:command-palette-input#onClear keypress:command-palette-input#onClear" data-target="command-palette-input.clearButton" id="command-palette-clear-button" hidden="hidden" type="button" data-view-component="true" class="btn-octicon command-palette-input-clear-button"><svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-x-circle-fill">
<path fill-rule="evenodd" d="M2.343 13.657A8 8 0 1113.657 2.343 8 8 0 012.343 13.657zM6.03 4.97a.75.75 0 00-1.06 1.06L6.94 8 4.97 9.97a.75.75 0 101.06 1.06L8 9.06l1.97 1.97a.75.75 0 101.06-1.06L9.06 8l1.97-1.97a.75.75 0 10-1.06-1.06L8 6.94 6.03 4.97z"></path>
</svg></button>
<tool-tip hidden="hidden" for="command-palette-clear-button" data-direction="w" data-type="description" data-view-component="true">Clear</tool-tip>
</command-palette-input>
<command-palette-page-stack
data-default-scope-id="PR_kwDOABII5845n4CA"
data-default-scope-type="PullRequest"
data-action="command-palette-page-octicons-cached:command-palette-page-stack#cacheOcticons"
>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["","owner","repository"]"
data-mode=""
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type <kbd class="hx_kbd">#</kbd> to search pull requests
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["","owner","repository"]"
data-mode=""
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type <kbd class="hx_kbd">#</kbd> to search issues
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["owner","repository"]"
data-mode=""
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type <kbd class="hx_kbd">#</kbd> to search discussions
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["owner","repository"]"
data-mode=""
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type <kbd class="hx_kbd">!</kbd> to search projects
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["owner"]"
data-mode=""
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type <kbd class="hx_kbd">@</kbd> to search teams
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="[""]"
data-mode=""
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type <kbd class="hx_kbd">@</kbd> to search people and organizations
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["","owner","repository"]"
data-mode=""
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type <kbd class="hx_kbd">></kbd> to activate command mode
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["","owner","repository"]"
data-mode=""
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Go to your accessibility settings to change your keyboard shortcuts
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["","owner","repository"]"
data-mode="#"
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type author:@me to search your content
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["","owner","repository"]"
data-mode="#"
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type is:pr to filter to pull requests
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["","owner","repository"]"
data-mode="#"
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type is:issue to filter to issues
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["owner","repository"]"
data-mode="#"
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type is:project to filter to projects
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip
class="color-fg-muted f6 px-3 py-1 my-2"
data-scope-types="["","owner","repository"]"
data-mode="#"
data-value="">
<div class="d-flex flex-items-start flex-justify-between">
<div>
<span class="text-bold">Tip:</span>
Type is:open to filter to open content
</div>
<div class="ml-2 flex-shrink-0">
Type <kbd class="hx_kbd">?</kbd> for help and tips
</div>
</div>
</command-palette-tip>
<command-palette-tip class="mx-3 my-2 flash flash-error d-flex flex-items-center" data-scope-types="*" data-on-error>
<div>
<svg aria-hidden="true" height="16" viewBox="0 0 16 16" version="1.1" width="16" data-view-component="true" class="octicon octicon-alert">
<path fill-rule="evenodd" d="M8.22 1.754a.25.25 0 00-.44 0L1.698 13.132a.25.25 0 00.22.368h12.164a.25.25 0 00.22-.368L8.22 1.754zm-1.763-.707c.659-1.234 2.427-1.234 3.086 0l6.082 11.378A1.75 1.75 0 0114.082 15H1.918a1.75 1.75 0 01-1.543-2.575L6.457 1.047zM9 11a1 1 0 11-2 0 1 1 0 012 0zm-.25-5.25a.75.75 0 00-1.5 0v2.5a.75.75 0 001.5 0v-2.5z"></path>
</svg>
</div>
<div class="px-2">
We’ve encountered an error and some results aren't available at this time. Type a new search or try again later.
</div>
</command-palette-tip>
<command-palette-tip class="h4 color-fg-default pl-3 pb-2 pt-3" data-on-empty data-scope-types="*" data-match-mode="[^?]|^$">
No results matched your search
</command-palette-tip>
<div hidden>
<div data-targets="command-palette-page-stack.localOcticons" data-octicon-id="arrow-right-color-fg-muted">
<svg height="16" class="octicon octicon-arrow-right color-fg-muted" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path fill-rule="evenodd" d="M8.22 2.97a.75.75 0 011.06 0l4.25 4.25a.75.75 0 010 1.06l-4.25 4.25a.75.75 0 01-1.06-1.06l2.97-2.97H3.75a.75.75 0 010-1.5h7.44L8.22 4.03a.75.75 0 010-1.06z"></path></svg>
</div>
<div data-targets="command-palette-page-stack.localOcticons" data-octicon-id="arrow-right-color-fg-default">
<svg height="16" class="octicon octicon-arrow-right color-fg-default" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path fill-rule="evenodd" d="M8.22 2.97a.75.75 0 011.06 0l4.25 4.25a.75.75 0 010 1.06l-4.25 4.25a.75.75 0 01-1.06-1.06l2.97-2.97H3.75a.75.75 0 010-1.5h7.44L8.22 4.03a.75.75 0 010-1.06z"></path></svg>
</div>
<div data-targets="command-palette-page-stack.localOcticons" data-octicon-id="codespaces-color-fg-muted">
<svg height="16" class="octicon octicon-codespaces color-fg-muted" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path fill-rule="evenodd" d="M2 1.75C2 .784 2.784 0 3.75 0h8.5C13.216 0 14 .784 14 1.75v5a1.75 1.75 0 01-1.75 1.75h-8.5A1.75 1.75 0 012 6.75v-5zm1.75-.25a.25.25 0 00-.25.25v5c0 .138.112.25.25.25h8.5a.25.25 0 00.25-.25v-5a.25.25 0 00-.25-.25h-8.5zM0 11.25c0-.966.784-1.75 1.75-1.75h12.5c.966 0 1.75.784 1.75 1.75v3A1.75 1.75 0 0114.25 16H1.75A1.75 1.75 0 010 14.25v-3zM1.75 11a.25.25 0 00-.25.25v3c0 .138.112.25.25.25h12.5a.25.25 0 00.25-.25v-3a.25.25 0 00-.25-.25H1.75z"></path><path fill-rule="evenodd" d="M3 12.75a.75.75 0 01.75-.75h.5a.75.75 0 010 1.5h-.5a.75.75 0 01-.75-.75zm4 0a.75.75 0 01.75-.75h4.5a.75.75 0 010 1.5h-4.5a.75.75 0 01-.75-.75z"></path></svg>
</div>
<div data-targets="command-palette-page-stack.localOcticons" data-octicon-id="copy-color-fg-muted">
<svg height="16" class="octicon octicon-copy color-fg-muted" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path fill-rule="evenodd" d="M0 6.75C0 5.784.784 5 1.75 5h1.5a.75.75 0 010 1.5h-1.5a.25.25 0 00-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 00.25-.25v-1.5a.75.75 0 011.5 0v1.5A1.75 1.75 0 019.25 16h-7.5A1.75 1.75 0 010 14.25v-7.5z"></path><path fill-rule="evenodd" d="M5 1.75C5 .784 5.784 0 6.75 0h7.5C15.216 0 16 .784 16 1.75v7.5A1.75 1.75 0 0114.25 11h-7.5A1.75 1.75 0 015 9.25v-7.5zm1.75-.25a.25.25 0 00-.25.25v7.5c0 .138.112.25.25.25h7.5a.25.25 0 00.25-.25v-7.5a.25.25 0 00-.25-.25h-7.5z"></path></svg>
</div>
<div data-targets="command-palette-page-stack.localOcticons" data-octicon-id="dash-color-fg-muted">
<svg height="16" class="octicon octicon-dash color-fg-muted" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path fill-rule="evenodd" d="M2 7.75A.75.75 0 012.75 7h10a.75.75 0 010 1.5h-10A.75.75 0 012 7.75z"></path></svg>
</div>
<div data-targets="command-palette-page-stack.localOcticons" data-octicon-id="file-color-fg-muted">
<svg height="16" class="octicon octicon-file color-fg-muted" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path fill-rule="evenodd" d="M3.75 1.5a.25.25 0 00-.25.25v12.5c0 .138.112.25.25.25h9.5a.25.25 0 00.25-.25V6h-2.75A1.75 1.75 0 019 4.25V1.5H3.75zm6.75.062V4.25c0 .138.112.25.25.25h2.688a.252.252 0 00-.011-.013l-2.914-2.914a.272.272 0 00-.013-.011zM2 1.75C2 .784 2.784 0 3.75 0h6.586c.464 0 .909.184 1.237.513l2.914 2.914c.329.328.513.773.513 1.237v9.586A1.75 1.75 0 0113.25 16h-9.5A1.75 1.75 0 012 14.25V1.75z"></path></svg>
</div>
<div data-targets="command-palette-page-stack.localOcticons" data-octicon-id="gear-color-fg-muted">
<svg height="16" class="octicon octicon-gear color-fg-muted" viewBox="0 0 16 16" version="1.1" width="16" aria-hidden="true"><path fill-rule="evenodd" d="M7.429 1.525a6.593 6.593 0 011.142 0c.036.003.108.036.137.146l.289 1.105c.147.56.55.967.997 1.189.174.086.341.183.501.29.417.278.97.423 1.53.27l1.102-.303c.11-.03.175.016.195.046.219.31.41.641.573.989.014.031.022.11-.059.19l-.815.806c-.411.406-.562.957-.53 1.456a4.588 4.588 0 010 .582c-.032.499.119 1.05.53 1.456l.815.806c.08.08.073.159.059.19a6.494 6.494 0 01-.573.99c-.02.029-.086.074-.195.045l-1.103-.303c-.559-.153-1.112-.008-1.529.27-.16.107-.327.204-.5.29-.449.222-.851.628-.998 1.189l-.289 1.105c-.029.11-.101.143-.13…
achow101
added a commit
that referenced
this pull request
May 1, 2023
…acy wallets 9141e43 rpc, docs: Add note for commands that supports only legacy wallets (Yusuf Sahin HAMZA) Pull request description: Refs #25363, apparently issue is not updated since over a month, so i decided to put the same `importaddress` note in #25368 to other rpc commands that needs this note. Note is added for following commands: - `importprivkey` - `importpubkey` - `importwallet` - `dumpprivkey` - `dumpwallet` - `importmulti` - `addmultisigaddress` - `sethdseed` ACKs for top commit: achow101: ACK 9141e43 Tree-SHA512: f3dc05d26577fd8dbe2bd69cb5c14ffccebacd6010402af44427b3d01be8484895dfcf33d55dfa766eadb7f9f3bae5cc4c2add3ac816a2ac60e8beb5a97527f3
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 1, 2023
…nly legacy wallets 9141e43 rpc, docs: Add note for commands that supports only legacy wallets (Yusuf Sahin HAMZA) Pull request description: Refs bitcoin#25363, apparently issue is not updated since over a month, so i decided to put the same `importaddress` note in bitcoin#25368 to other rpc commands that needs this note. Note is added for following commands: - `importprivkey` - `importpubkey` - `importwallet` - `dumpprivkey` - `dumpwallet` - `importmulti` - `addmultisigaddress` - `sethdseed` ACKs for top commit: achow101: ACK 9141e43 Tree-SHA512: f3dc05d26577fd8dbe2bd69cb5c14ffccebacd6010402af44427b3d01be8484895dfcf33d55dfa766eadb7f9f3bae5cc4c2add3ac816a2ac60e8beb5a97527f3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #25363 and offers a small update to the error messages from
EnsureLegacyScriptPubKeyManandEnsureConstLegacyScriptPubKeyManto mention that they only are compatible with legacy wallets.The RPC documentation for
importaddressis also updated to mention this as well as guide the user to the alternativeimportdescriptorsfor cases when using descriptor wallets.I'm thinking that we can introduce a "porting guide" document mentioned in #25363 in a separate PR since I would have to make myself more familiar with the subject before being able to tackle that.