test: remove wallet dependency from feature_nulldummy.py #25364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK, thanks for working on disentangling more tests from the wallet. |
ayush933
force-pushed
the
nulldummy_no_wallet
branch
from
b02411d to
a8fe321
Compare
maflcko
reviewed
Jun 14, 2022
ayush933
force-pushed
the
nulldummy_no_wallet
branch
from
a8fe321 to
9a783a9
Compare
kouloumos
reviewed
Jun 19, 2022
Contributor
kouloumos
left a comment
kouloumos
left a comment
There was a problem hiding this comment.
ACK 9a783a9fd76ee5350d64ed1ed5b658c530913653 with some minor comments that i believe could increase readability.
I was also thinking that using the MiniWallet could potentially simplify the test and I tried to validate my intuition, but it seems that the changes needed do not justify the idea.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
maflcko
reviewed
Jun 21, 2022
This test can now be run even with the Bitcoin Core wallet disabled.
ayush933
force-pushed
the
nulldummy_no_wallet
branch
from
9a783a9 to
eec23da
Compare
the functions `create_transaction()` and `create_raw_transaction()` were no longer used hence removed.
Contributor
Author
|
Thanks a lot @MarcoFalke and @kouloumos for the thorough reviews. |
Contributor
|
re-ACK 50ba669, all comments have been addressed. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 30, 2022
…dummy.py 50ba669 remove unused functions (Ayush Sharma) eec23da test: remove wallet dependency from feature_nulldummy.py (Ayush Sharma) Pull request description: This PR enables one of the non-wallet functional tests (`feature_nulldummy.py`) to be run even with the Bitcoin Core wallet disabled. Commit 1: removes wallet dependency and `test_runner.py` is edited to make sure the test only runs once. Commit 2: the functions `create_transaction()` and `create_raw_transaction()` in `blocktools.py` are no longer needed and hence removed. ACKs for top commit: kouloumos: re-ACK 50ba669, all comments have been addressed. Tree-SHA512: 3bc3d2766e53dba3d56a03f2c476442608ac693f51d84f4632a22a2cf169bc02c10bf92b676f7d57acb4f0ad86f307d37ab63f936b44b3585ee3c9d08cd0335f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables one of the non-wallet functional tests (
feature_nulldummy.py) to be run even with the Bitcoin Core wallet disabled.Commit 1: removes wallet dependency and
test_runner.pyis edited to make sure the test only runs once.Commit 2: the functions
create_transaction()andcreate_raw_transaction()inblocktools.pyare no longer needed and hence removed.