test: Fix out-of-range port collisions #25333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The failure would only be intermittent (maybe with a probability of 1%?) |
dergoegge
reviewed
Jun 10, 2022
maflcko
force-pushed
the
2206-test-collide-
branch
from
fa46ea0 to
fa7a711
Compare
dergoegge
reviewed
Jun 10, 2022
Member
dergoegge
left a comment
dergoegge
left a comment
There was a problem hiding this comment.
ACK fa7a711 - This gets rid of some rather arbitrary choices for ports in some of our functional tests that can cause port collisions across test runs, resulting in intermittent failures.
Using left over p2p ports (p2p_port(n)) for custom ports seems OK. In the long run (if needed) we could consider adding a third port range to the tests for custom ports (as suggested in #25096 (comment)).
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 13, 2022
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 27, 2023
Summary: Otherwise the test will fail if two tests running in parallel use the same port. Backport of [[bitcoin/bitcoin#25333 | core#25333]] and [[bitcoin/bitcoin#25312 | core#25312]]. Test Plan: ./test/functional/test_runner.py feature_proxy feature_bind_extra p2p_getaddr_caching Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D13810
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the test will fail if two tests running in parallel use the same port. See #25096 (comment) and #25312