Skip to content

doc: fix typo in kernel/context.h and add desig to ignore-words #25307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 2 commits into from
Jun 9, 2022
Merged

doc: fix typo in kernel/context.h and add desig to ignore-words #25307

fanquake merged 2 commits into from
Jun 9, 2022

Conversation

@brunoerg
Copy link
Contributor

@brunoerg brunoerg commented Jun 8, 2022

This PR fixes a typo in kernel/context.h (libary => library) and add desig to ignore-words since it's a valid word, see:

bitcoin/src/net.cpp

Lines 1105 to 1117 in b9416c3

NodeEvictionCandidate candidate{
Desig(id) node->GetId(),
Desig(m_connected) node->m_connected,
Desig(m_min_ping_time) node->m_min_ping_time,
Desig(m_last_block_time) node->m_last_block_time,
Desig(m_last_tx_time) node->m_last_tx_time,
Desig(fRelevantServices) HasAllDesirableServiceFlags(node->nServices),
Desig(m_relay_txs) node->m_relays_txs.load(),
Desig(fBloomFilter) node->m_bloom_filter_loaded.load(),
Desig(nKeyedNetGroup) node->nKeyedNetGroup,
Desig(prefer_evict) node->m_prefer_evict,
Desig(m_is_local) node->addr.IsLocal(),
Desig(m_network) node->ConnectedThroughNetwork(),

fanquake
fanquake reviewed Jun 9, 2022
View reviewed changes
@fanquake fanquake mentioned this pull request Jun 9, 2022
Merged
@brunoerg brunoerg force-pushed the 2022-06-fix-typo-kernel branch from 66b9522 to d575413 Compare June 9, 2022 12:17
@brunoerg brunoerg requested a review from fanquake June 9, 2022 12:17
fanquake
fanquake approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d575413

@fanquake fanquake merged commit e3c08eb into bitcoin:master Jun 9, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 13, 2022
@fanquake
Merge bitcoin#25307: doc: fix typo in kernel/context.h and add `desig…
9d2fde5 
…` to ignore-words

d575413 doc: add `desig` to ignore-words (brunoerg)
c06cc41 doc: fix typo in kernel/context.h (brunoerg)

Pull request description:

  This PR fixes a typo in `kernel/context.h` (libary => library) and add `desig` to ignore-words since it's a valid word, see:
  https://github.com/bitcoin/bitcoin/blob/b9416c3847cd347238a9d75d949327f69e187d79/src/net.cpp#L1105-L1117

ACKs for top commit:
  fanquake:
    ACK d575413

Tree-SHA512: 2d548c737b8184d0243445c7503f3f68256ecb0970bd834d52de099de3cd8c8b9c140e2b77d55e2542fbd45b1d21cbdee639f5b2ef8138c37b8b72e5211029c3
@bitcoin bitcoin locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanquake fanquake fanquake approved these changes

Assignees

No one assigned

Labels

Validation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brunoerg @fanquake @DrahtBot