Move DEFAULT_ANCESTOR_LIMIT to policy/settings #25295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
glozow
reviewed
Jun 7, 2022
|
|
||
| /** Default for -limitancestorcount, max number of in-mempool ancestors */ | ||
| static const unsigned int DEFAULT_ANCESTOR_LIMIT = 25; | ||
| /** Default for -limitancestorsize, maximum kilobytes of tx + all in-mempool ancestors */ |
Member
There was a problem hiding this comment.
The rest should be moved too, as stated in the comment.
DEFAULT_ANCESTOR_LIMIT
DEFAULT_ANCESTOR_SIZE_LIMIT
DEFAULT_DESCENDANT_LIMIT
DEFAULT_DESCENDANT_SIZE_LIMIT
DEFAULT_MEMPOOL_EXPIRY
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
2 tasks
Member
|
Closing for now due to inactivity. Since there hasn't been any substantial discussion on this pull request, feel free to open a new one. If you do, make sure to squash the commits according to the contributing guidelines. |
Member
|
Picked up in #25388. |
laanwj
added a commit
that referenced
this pull request
Jun 20, 2022
0d8e68d refactor: move DEFAULT_*_LIMIT assertions from validation to policy (fanquake) 9c94f3b refactor: move EXTRA_DESCENDANT_TX_SIZE_LIMIT to policy/policy.h (fanquake) 39c6036 refactor: use braced initialization in policy/policy.h (fanquake) 01ccfbe scripted-diff: use static constexpr in policy/policy.h (fanquake) 62d56bb refactor: Move DEFAULT_DESCENDANT_SIZE_LIMIT to policy/policy.h (fanquake) a34aa4c refactor: Move DEFAULT_DESCENDANT_LIMIT to policy/policy.h (fanquake) 05fc5fd refactor: Move DEFAULT_ANCESTOR_SIZE_LIMIT to policy/policy.h (fanquake) da8d304 refactor: Move DEFAULT_ANCESTOR_LIMIT to policy/policy.h (CAnon) Pull request description: Picks up #25295. Which was a follow up to [a comment in #25254](#25254 (comment)). Moves policy constants from validation.h to policy.h. ACKs for top commit: laanwj: Code review ACK 0d8e68d w0xlt: reACK 0d8e68d darosior: ACK 0d8e68d Tree-SHA512: 79900b09dc3a8020b5053ec734f462cb6e8184ed2b76e9d8afae7fe5331bbc906daaa42c0f622782797d971aaf5698aa0155511ec1d15582cc7675c271664a8d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up commit from #25254 (comment)
This commit moves ancestor limit from validation to policy/settings.