test: Fix wait_for_debug_log UnicodeDecodeError #25294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
2206-test-emoji-decode-
branch
from
faf4c03 to
fa74b63
Compare
Member
|
ACK fa74b63 |
brunoerg
approved these changes
Jun 8, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 13, 2022
fa74b63 test: Fix wait_for_debug_log UnicodeDecodeError (MacroFake) Pull request description: Fix the intermittent `UnicodeDecodeError` when the debug log is truncated on an (multi-byte) unicode character by treating everything as bytes. Also, remove the `ignore_case` option and the`re.search+re.escape` wrap. All of this is unused and doesn't exist on raw byte strings. Fixes bitcoin#24575 ACKs for top commit: jonatack: ACK fa74b63 brunoerg: ACK fa74b63 Tree-SHA512: c67c9355073e784fa8d9d48b8e79ff0c98f5ae9cd4d704ad12a76d2604733946054bc74b8ab346aa2184db23d740b85c8c13eb892d76cba92e42ebfd73f2f1bf
Contributor
|
@MarcoFalke I think line 451 of test_node.py is now broken.
This could work |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 25, 2022
Summary: > Fix the intermittent UnicodeDecodeError when the debug log is truncated on an (multi-byte) unicode character by treating everything as bytes. > > Also, remove the ignore_case option and there.search+re.escape wrap. All of this is unused and doesn't exist on raw byte strings. This is a backport of [[bitcoin/bitcoin#25294 | core#25294]] Depends on D12622 Note: I added a typehint for `expected_msgs` because imo the parameter name is now misleading with regards to its type. This allowed the mypy linter to detect that a subsequent line defining `print_log` is now broken because `log` is now of type `bytes` and you cannot join `bytes` with `str` Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D12624
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the intermittent
UnicodeDecodeErrorwhen the debug log is truncated on an (multi-byte) unicode character by treating everything as bytes.Also, remove the
ignore_caseoption and there.search+re.escapewrap. All of this is unused and doesn't exist on raw byte strings.Fixes #24575