Add LogPrintLevel to lint-format-strings, drop LogPrint-vs-LogPrintf section in dev notes #25292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…section in dev notes that was added in 2015 by commit b8c06ef in PR 7003, as that potential issue would now be caught by the test/lint/lint-format-strings.py script run by the CI
Member
Author
|
Was wondering whether to update that section in the developer notes with |
Member
|
cr ACK 433b525 |
w0xlt
approved these changes
Jun 7, 2022
maflcko
reviewed
Jun 7, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 8, 2022
…ogPrint-vs-LogPrintf section in dev notes 433b525 Add LogPrintLevel to lint-format-strings, drop LogPrint-vs-LogPrintf section in dev notes (Jon Atack) Pull request description: added by bitcoin#7003 in 2015, as that potential issue would now be caught by the `test/lint/lint-format-strings.py` script run by the CI. ACKs for top commit: MarcoFalke: cr ACK 433b525 w0xlt: ACK bitcoin@433b525 Tree-SHA512: 91a2ac76689ed4f1f638e07c16d2ec8952fb013cc8bb896780fbd9333abd084281ce99afdc9de715d07a9abb4dce5dd67edf5e347aff466c6ef339ccc4158679
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added by #7003 in 2015, as that potential issue would now be caught by the
test/lint/lint-format-strings.pyscript run by the CI.