test: Reliably don't start itself (lint-all.py runs all tests twice) #25288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinus
changed the title
Contributor
|
Concept ACK. Good catch! |
Member
|
It doesn't run twice in CI, right? For example, looking at https://cirrus-ci.com/task/4523243527733248?logs=lint#L849 I can only find the error once. |
Contributor
Author
|
Ah, in |
Member
|
May I propose a different solution: to rename the launcher so that it doesn't match the glob. This is 100% reliable and imo more elegant. |
Member
|
Yeah, could rename to |
That way it is impossible for the script to call itself.
Removed th check against __file__ which is not necessary any more after the rename to all-lint.py. Changed glob to find only `lint-*.py` scripts.
martinus
force-pushed
the
2022-06-fix-lint-all-starting-itself
branch
from
2f1f9e3 to
f26a496
Compare
Member
|
Code review ACK f26a496 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 8, 2022
…uns all tests twice) f26a496 test: clean up all-lint.py (Martin Leitner-Ankerl) 64d72c4 test: rename lint-all.py to all-lint.py (Martin Leitner-Ankerl) Pull request description: When running `./test/lint/lint-all.py`, the script runs all tests but also calls itself because the comparison with `__file__` doesn't work. Comparing resolved paths gives reliable comparison, and lint-all.py doesn't call itself any more ACKs for top commit: laanwj: Code review ACK f26a496 Tree-SHA512: b44abdd685f7b48a6a9f48e96d97138b635c31c1c7ab543cb5636b5f49690ccd56fa6fec01ae7fcc16af01a613372ee77632f70c32059919b373aa8051953791
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
./test/lint/lint-all.py, the script runs all tests butalso calls itself because the comparison with
__file__doesn't work.Comparing resolved paths gives reliable comparison, and lint-all.py doesn't call itself any more